Skip to content

fix(@angular/build): correctly wrap class expressions with static properties or blocks emitted by esbuild#27667

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:wrap-static-props
May 21, 2024
Merged

fix(@angular/build): correctly wrap class expressions with static properties or blocks emitted by esbuild#27667
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:wrap-static-props

Conversation

@alan-agius4
Copy link
Collaborator

Prior to this commit, class expressions emitted by esbuild that have static blocks or properties were not being properly wrapped. This caused the class to become non-treeshakable.

Closes #27662

…perties or blocks emitted by esbuild

Prior to this commit, class expressions emitted by esbuild that have static blocks or properties were not being properly wrapped. This caused the class to become non-treeshakable.

Closes angular#27662
@alan-agius4 alan-agius4 requested a review from clydin May 21, 2024 09:09
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 21, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 21, 2024
@alan-agius4 alan-agius4 merged commit ac9fc72 into angular:main May 21, 2024
@alan-agius4 alan-agius4 deleted the wrap-static-props branch May 21, 2024 13:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library tree-shaking doesn't seem to work with 18 RC

2 participants