Skip to content

fix(@angular/build): add a maximum rendering timeout for SSG#27579

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:ssg-timeout
May 2, 2024
Merged

fix(@angular/build): add a maximum rendering timeout for SSG#27579
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:ssg-timeout

Conversation

@alan-agius4
Copy link
Collaborator

There might be cases were currently, the render application promise does not resolve because the application never becomes stable in most cases this is due to errors, this causes the worker to never exit and the build to keep running until it's manually terminated.

With this change, we add a maximum rendering timeout of 30seconds for each page.

Closes #27565

There might be cases were currently, the render application promise does not resolve because the application never becomes stable in most cases this is due to errors, this causes the worker to never exit and the build to keep running until it's manually terminated.

With this change, we add a maximum rendering timeout of 30seconds for each page.

Closes angular#27565
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 2, 2024
@alan-agius4 alan-agius4 requested a review from clydin May 2, 2024 11:35
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 2, 2024
@alan-agius4 alan-agius4 merged commit 59b69f5 into angular:main May 2, 2024
@alan-agius4 alan-agius4 deleted the ssg-timeout branch May 2, 2024 14:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng build hangs without error or warning.

2 participants