Skip to content

fix(@schematics/angular): retain trailing comma when adding providers to app config#26929

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:trailing-comma
Jan 23, 2024
Merged

fix(@schematics/angular): retain trailing comma when adding providers to app config#26929
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:trailing-comma

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

This fixes an issue which caused the new provider to be added in the position of the trailing comma. With this change the trailing comma is retained.

Closes #26911

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 23, 2024
@alan-agius4 alan-agius4 requested a review from clydin January 23, 2024 10:24
… to app config

This fixes an issue which caused the new provider to be added in the position of the trailing comma. With this change the trailing comma is retained.

Closes angular#26911
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 23, 2024
@alan-agius4 alan-agius4 merged commit 90363dd into angular:main Jan 23, 2024
@alan-agius4 alan-agius4 deleted the trailing-comma branch January 23, 2024 17:35
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular CLI SSR Configuration removes trailing comma in AppConfig, resulting in Syntax Errors

2 participants