fix(@schematics/angular): add missing express REQUEST and RESPONSE tokens#26175
Conversation
…` tokens This commit updates the nguniversal migration to add `REQUEST` and `RESPONSE` tokens. Closes angular#26110
|
@alan-agius4 Whats the new package that exports these? I just ran the |
|
@alan-agius4 did you get a chance to look at this? |
|
The tokens are no longer exporting from a package. Instead the migration will create them in the project when encountering imports to |
Thanks. I was expecting that after looking at PR.
You can run the migration on here https://github.com/stevermeister/ngx-cookie-service and reproduce the issue |
|
Are you importing the import { InjectionToken } from '@angular/core';
import { Request, Response } from 'express';
export const REQUEST = new InjectionToken<Request>('REQUEST');
export const RESPONSE = new InjectionToken<Response>('RESPONSE'); |
I think so. You can see them here https://github.com/stevermeister/ngx-cookie-service/blob/test/projects/ngx-cookie-service-ssr/src/lib/ssr-cookie.service.ts |
It seems like an issue with PNPM. When I tried with NPM I don't see an issue. But PNPM gives that error. Any idea why? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit updates the nguniversal migration to add
REQUESTandRESPONSEtokens.Closes #26110