fix(@angular/cli): error if Angular compiler is used in a schematic#24662
Merged
angular-robot[bot] merged 1 commit intoangular:mainfrom Feb 7, 2023
Merged
fix(@angular/cli): error if Angular compiler is used in a schematic#24662angular-robot[bot] merged 1 commit intoangular:mainfrom
angular-robot[bot] merged 1 commit intoangular:mainfrom
Conversation
When a schematic is executed, it is wrapped in a custom Node context. This context doesn't expose the same set of global variables. This can lead to an error if a schematic is importing the Angular compiler and the app is using i18n, because the `TextEncoder` isn't exposed through the custom context (see angular/angular#48940). These changes add the `TextEncoder` to the context. Fixes angular/angular#48940.
crisbeto
commented
Feb 5, 2023
| import { parse as parseJson } from 'jsonc-parser'; | ||
| import { createRequire } from 'module'; | ||
| import { dirname, resolve } from 'path'; | ||
| import { TextEncoder } from 'util'; |
Member
Author
There was a problem hiding this comment.
I used an import for this, even though it's available globally, because for some reason the global variable wasn't in the typings.
alan-agius4
approved these changes
Feb 6, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a schematic is executed, it is wrapped in a custom Node context. This context doesn't expose the same set of global variables as the default one. This can lead to an error if a schematic is importing the Angular compiler and the app is using i18n, because the
TextEncoderisn't exposed through the custom context (see angular/angular#48940).These changes add the
TextEncoderto the context.Fixes angular/angular#48940.