fix(@angular/cli): add builders and schematic names as page titles in collected analytics#23718
Conversation
82cc02a to
05a0b28
Compare
packages/angular/cli/src/command-builder/architect-base-command-module.ts
Outdated
Show resolved
Hide resolved
05a0b28 to
a12f5f4
Compare
|
Currently figuring out the privacy approval process for this change, so don't merge this just yet. |
a12f5f4 to
92965e0
Compare
dgp1130
left a comment
There was a problem hiding this comment.
LGTM, just waiting on privacy before approving.
… collected analytics With this commit the builder and schematic names are added as page title to page events. Also, we address a bug where during a watch or error in some cases analytics where not flushed. Examples when the builder has a watch mode.
92965e0 to
01e7abd
Compare
|
I just realized we also list out the data collected on AIO: https://angular.io/analytics#what-is-collected. We should update that as well when this is ready to land. |
|
This is fully privacy approved, so we're good to merge this in and release: http://launch/4185851. Don't forget to update https://angular.io/analytics#what-is-collected, whether in this PR or another one. |
Awesome. Has to be a separate PR as it's a different repo. EDIT: angular/angular#47529 |
This commit adds more information on what is collected by the Angular CLI as with angular/angular-cli#23718 we will collect additional information.
This commit adds more information on what is collected by the Angular CLI as with angular/angular-cli#23718 we will collect additional information. PR Close #47529
This commit adds more information on what is collected by the Angular CLI as with angular/angular-cli#23718 we will collect additional information. PR Close #47529
sleepynano
left a comment
There was a problem hiding this comment.
packages/angular/cli/src/command-builder/schematics-command-module.ts
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With this commit the builder and schematic names are added as page title to page events.
Also, we address a bug where during a watch or error in some cases analytics where not flushed. Examples when the builder has a watch mode.