Skip to content

fix(@angular-devkit/build-angular): fix incorrect glob cwd in karma when using --include option#23401

Merged
dgp1130 merged 1 commit intoangular:mainfrom
alan-agius4:karma-include-specs
Jun 21, 2022
Merged

fix(@angular-devkit/build-angular): fix incorrect glob cwd in karma when using --include option#23401
dgp1130 merged 1 commit intoangular:mainfrom
alan-agius4:karma-include-specs

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jun 20, 2022

Previously, we amended the project source root to the source root which resulted in an invalid path.

Closes #23396

…hen using `--include` option

Previously, we amended the project source root to the source root which resulted in an invalid path.

Closes angular#23396
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 20, 2022
@alan-agius4 alan-agius4 requested a review from clydin June 20, 2022 08:36
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 21, 2022
@dgp1130 dgp1130 merged commit 6677994 into angular:main Jun 21, 2022
@alan-agius4 alan-agius4 deleted the karma-include-specs branch June 21, 2022 19:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng test --include is broken

3 participants