Skip to content

fix(@angular-devkit/build-angular): replace dev-server socket path from /ws to /ng-cli-ws#23266

Merged
dgp1130 merged 1 commit intoangular:mainfrom
alan-agius4:web-socket-path
Jun 2, 2022
Merged

fix(@angular-devkit/build-angular): replace dev-server socket path from /ws to /ng-cli-ws#23266
dgp1130 merged 1 commit intoangular:mainfrom
alan-agius4:web-socket-path

Conversation

@alan-agius4
Copy link
Collaborator

In some cases /ws caused conflicts with local websocket connections. Hence we change the dev-server web socket path to something more specific to the Angular CLI.

Closes #23260

@alan-agius4 alan-agius4 added state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 2, 2022
…om `/ws` to `/ng-cli-ws`

In some cases `/ws` caused conflicts with local websocket connections. Hence we change the dev-server web socket path to something more specific to the Angular CLI.

Closes angular#23260
@alan-agius4 alan-agius4 changed the title fix(@angular/devkit/build-angular): replace dev-server socket path from /ws to /ng-cli-ws fix(@angular-devkit/build-angular): replace dev-server socket path from /ws to /ng-cli-ws Jun 2, 2022
@alan-agius4 alan-agius4 requested a review from dgp1130 June 2, 2022 10:38
@alan-agius4 alan-agius4 marked this pull request as ready for review June 2, 2022 10:39
@alan-agius4 alan-agius4 removed the request for review from dgp1130 June 2, 2022 14:32
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 2, 2022
@dgp1130 dgp1130 merged commit 9301699 into angular:main Jun 2, 2022
@alan-agius4 alan-agius4 deleted the web-socket-path branch June 2, 2022 20:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After upgrading from 12 to 13, the live reload websocket URL path /ws/ conflicts with the application when using the same path

3 participants