fix(@angular/cli): support silent package installs with Yarn 2+#23242
Merged
clydin merged 2 commits intoangular:mainfrom May 27, 2022
Merged
fix(@angular/cli): support silent package installs with Yarn 2+#23242clydin merged 2 commits intoangular:mainfrom
clydin merged 2 commits intoangular:mainfrom
Conversation
Yarn 2 and higher no longer support the `--silent` flag. The Angular CLI will now spawn package managers with the stdout ignored when silent mode is needed and only show stderr when the process exits unsuccessfully. This provides the necessary functionality for the CLI without relying on package manager options.
alan-agius4
approved these changes
May 27, 2022
Collaborator
alan-agius4
left a comment
There was a problem hiding this comment.
This should resolve #22048
Also, this change should also be done in https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/schematics/tasks/package-manager/install-task.ts
Member
Author
|
Working on that now. Once both are in that should resolve the referenced issue regarding the |
…Yarn 2+ Yarn 2 and higher no longer support the `--silent` flag. The `NodePackageInstallTask` will now spawn package managers with the stdout ignored when quiet mode is needed and only show stderr when the process exits unsuccessfully. This provides the necessary functionality for the task without relying on package manager options.
alan-agius4
approved these changes
May 27, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yarn 2 and higher no longer support the
--silentflag.The Angular CLI will now spawn package managers with the stdout ignored when silent
mode is needed and only show stderr when the process exits unsuccessfully. This
provides the necessary functionality for the CLI without relying on package manager
options.