fix(core): disallow event attribute bindings in host bindings unconditionally#68438
Merged
Conversation
…tionally Moves the event attribute validation check outside of `ngDevMode` in the `elementAttributeInternal` instruction to ensure that bindings to event attributes like `on*` are always blocked at runtime. Previously, this check was only performed when `ngDevMode` was `true`, which could allow attacker-controlled CMS data to be bound to event attributes in production mode, causing browser-executed XSS. Fixes angular#68419
71ac674 to
e7726ac
Compare
JeanMeche
reviewed
Apr 29, 2026
josephperrott
approved these changes
Apr 29, 2026
josephperrott
left a comment
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
AndrewKushnir
approved these changes
Apr 29, 2026
315d323 to
5f06031
Compare
5f06031 to
5723317
Compare
AndrewKushnir
approved these changes
Apr 30, 2026
620c35a to
bd6fccf
Compare
bd6fccf to
65190ea
Compare
Member
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the event attribute validation check outside of
ngDevModein theelementAttributeInternalinstruction to ensure that bindings to event attributes likeon*are always blocked at runtime.Previously, this check was only performed when
ngDevModewastrue, which could allow attacker-controlled CMS data to be bound to event attributes in production mode, causing browser-executed XSS.Fixes #68419