Skip to content

refactor: Improve hydration mismatch errors for third-party scripts#68165

Merged
leonsenft merged 1 commit into
angular:mainfrom
aparzi:improved-error-message-for-third-party-scripts
Apr 17, 2026
Merged

refactor: Improve hydration mismatch errors for third-party scripts#68165
leonsenft merged 1 commit into
angular:mainfrom
aparzi:improved-error-message-for-third-party-scripts

Conversation

@aparzi

@aparzi aparzi commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Improves error messages shown during hydration mismatches to better surface cases where third-party scripts or browser extensions have modified the DOM outside of Angular's control.

Fixed #59224

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

Issue Number: #59224

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove Bot requested a review from devversion April 13, 2026 13:41
Comment thread packages/core/src/hydration/error_handling.ts Outdated
Comment thread packages/core/src/hydration/error_handling.ts Outdated
@aparzi aparzi force-pushed the improved-error-message-for-third-party-scripts branch from f6079b7 to c2f4f0b Compare April 13, 2026 19:56
@aparzi

aparzi commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

I updated the PR

Comment thread packages/core/src/hydration/error_handling.ts Outdated
Comment thread packages/platform-server/test/full_app_hydration_spec.ts Outdated
Improves error messages shown during hydration mismatches to better
surface cases where third-party scripts or browser extensions have
modified the DOM outside of Angular's control.

Fixed angular#59224
@aparzi aparzi force-pushed the improved-error-message-for-third-party-scripts branch from c2f4f0b to 6578a99 Compare April 14, 2026 07:59
@kirjs kirjs added the area: core Issues related to the framework runtime label Apr 14, 2026
@ngbot ngbot Bot added this to the Backlog milestone Apr 14, 2026

@thePunderWoman thePunderWoman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your work on this!

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 15, 2026
@JeanMeche JeanMeche removed the request for review from devversion April 15, 2026 08:09
@leonsenft

Copy link
Copy Markdown
Contributor

Failing internal tests appear to be flakes.

@leonsenft leonsenft merged commit d771a65 into angular:main Apr 17, 2026
29 of 32 checks passed
@leonsenft

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hydration resiliency: third party scripts that modify DOM and improved error messages

6 participants