Skip to content

fix(forms): Untrack setValue in reactive forms#67077

Merged
thePunderWoman merged 1 commit intoangular:mainfrom
JeanMeche:untrack-setValue
Feb 19, 2026
Merged

fix(forms): Untrack setValue in reactive forms#67077
thePunderWoman merged 1 commit intoangular:mainfrom
JeanMeche:untrack-setValue

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

Reasonably, writing to an AbstractControl shouldn't register signal reads.

fixes #67073

@JeanMeche JeanMeche added the action: global presubmit The PR is in need of a google3 global presubmit label Feb 15, 2026
@ngbot ngbot bot added this to the Backlog milestone Feb 15, 2026
Reasonably, writing to an `AbstractControl` shouldn't register signal reads.

fixes angular#67073
Copy link
Copy Markdown
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how breaking this is on TGP, but my instinct is that this can land as a fix in patch - it's genuinely a bug.

@JeanMeche
Copy link
Copy Markdown
Member Author

TGP returned a single breakage.

@alxhub
Copy link
Copy Markdown
Member

alxhub commented Feb 18, 2026

Yep, then let's land this in patch :)

@JeanMeche JeanMeche added target: patch This PR is targeted for the next patch release state: blocked on G3 cleanup This change requires a G3 cleanup target: minor This PR is targeted for the next minor release and removed breaking changes target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release labels Feb 18, 2026
@JeanMeche
Copy link
Copy Markdown
Member Author

(doesn't merge cleanly in patch, will create a patch PR seperately when this is merged)

@JeanMeche
Copy link
Copy Markdown
Member Author

TGP is green

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed state: blocked on G3 cleanup This change requires a G3 cleanup labels Feb 19, 2026
@thePunderWoman thePunderWoman marked this pull request as ready for review February 19, 2026 17:08
@thePunderWoman thePunderWoman removed the action: global presubmit The PR is in need of a google3 global presubmit label Feb 19, 2026
@thePunderWoman thePunderWoman merged commit 2061fd8 into angular:main Feb 19, 2026
31 checks passed
@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@JeanMeche JeanMeche deleted the untrack-setValue branch February 19, 2026 19:48
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: forms target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

formControl.setValue inside a reactive context causes tracking of all signals read by value/validity change subscribers

4 participants