fix(forms): Resolves debounce promise on abort in debounceForDuration#66650
Merged
leonsenft merged 1 commit intoangular:mainfrom Jan 30, 2026
Merged
Conversation
Ensures the promise returned by the debouncer resolves when aborted, preventing potential hangs for awaiting consumers. Fixes angular#66646
SkyZeroZx
commented
Jan 20, 2026
|
|
||
| const onAbort = () => { | ||
| clearTimeout(timeoutId); | ||
| resolve(); |
Contributor
Author
There was a problem hiding this comment.
I haven't found a way to replicate the problem mentioned with a test; however, I think it's right that we solve the problem to avoid any unexpected behavior or memory leak
Contributor
There was a problem hiding this comment.
Yeah, I agree this is correct. I don't believe we can properly unit test this without exporting the private debounceForDuration API.
Contributor
|
Thank you, I know @leonsenft is working in that area right now, so adding him as a reviewer |
leonsenft
approved these changes
Jan 26, 2026
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the promise returned by the debouncer resolves when aborted, preventing potential hangs for awaiting consumers. Fixes #66646
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #66646
What is the new behavior?
Does this PR introduce a breaking change?
Other information