Update error message links to versioned docs#66374
Update error message links to versioned docs#66374SkyZeroZx wants to merge 7 commits intoangular:mainfrom
Conversation
| const versionSubDomain = VERSION.major !== '0' ? `v${VERSION.major}.` : ''; | ||
| return `https://${versionSubDomain}angular.dev`; |
There was a problem hiding this comment.
We should also be able to link to next.angular.dev if the version have next/rc.
There was a problem hiding this comment.
I’ll try . I kept it as-is because, if I’m not mistaken, changing it would require updating some unit tests.
There was a problem hiding this comment.
Updated, now supports linking to next.angular.dev, update the respective tests
1e7bce3 to
7909500
Compare
Error message links now point to the archived documentation site (v*.angular.dev) so that referenced content matches the framework version in use. See angular#44650
Error message links now point to the archived documentation site (v*.angular.dev) so that referenced content matches the framework version in use. See angular#44650
7909500 to
774388b
Compare
packages/compiler-cli/src/ngtsc/typecheck/extended/checks/invalid_banana_in_box/index.ts
Outdated
Show resolved
Hide resolved
|
I also see that this change affects the forms/common tests, I’m going to update the other unit tests as well. |
packages/compiler-cli/src/ngtsc/diagnostics/src/error_details_base_url.ts
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/diagnostics/src/error_details_base_url.ts
Outdated
Show resolved
Hide resolved
|
caretaker note: This requires an update to a g3patch. You'll need to land cl/854258398 before this. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Align error message links with versioned documentation.
Add the following commits :
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #44650
What is the new behavior?
Does this PR introduce a breaking change?
Other information