Skip to content

feat(forms): add [formField] directive#66136

Merged
kirjs merged 1 commit intoangular:mainfrom
mmalerba:sf/field
Jan 6, 2026
Merged

feat(forms): add [formField] directive#66136
kirjs merged 1 commit intoangular:mainfrom
mmalerba:sf/field

Conversation

@mmalerba
Copy link
Copy Markdown
Contributor

No description provided.

@mmalerba mmalerba added target: patch This PR is targeted for the next patch release forms: signals labels Dec 17, 2025
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: forms labels Dec 17, 2025
@ngbot ngbot bot added this to the Backlog milestone Dec 17, 2025
@mmalerba mmalerba requested a review from kirjs December 17, 2025 21:47
Copy link
Copy Markdown
Contributor

@leonsenft leonsenft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Copy link
Copy Markdown
Contributor

@leonsenft leonsenft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2026
@angular angular deleted a comment from ngbot bot Jan 5, 2026
@mmalerba mmalerba removed request for alxhub and kirjs January 5, 2026 22:38
@mmalerba mmalerba added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 5, 2026
@mmalerba
Copy link
Copy Markdown
Contributor Author

mmalerba commented Jan 5, 2026

caretaker:

  1. pullapprove is wrong and refusing to pick up the latest review round
  2. this is a feature for an experimental API, ok to land in patch

This will replace the `[field]` directive, since `[field]` is a very
generic name for signal forms to commandeer

refactor(forms): hook up `formField` directive in compiler

Hooks up the `formField` direcive to get the same treatment as the
`field` directive in the compiler.

apply updated formatting
@kirjs kirjs merged commit 2d85ae5 into angular:main Jan 6, 2026
18 checks passed
@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Jan 6, 2026

This PR was merged into the repository. The changes were merged into the following branches:

mmalerba added a commit to mmalerba/angular that referenced this pull request Jan 9, 2026
This completes the rename started in angular#66136. `[field]` is too generic of
a selector for the forms system to own, and likely to cause naming
collisions with existing components. Therefore it is being renamed to
`[formField]`
mmalerba added a commit to mmalerba/angular that referenced this pull request Jan 9, 2026
This completes the rename started in angular#66136. `[field]` is too generic of
a selector for the forms system to own, and likely to cause naming
collisions with existing components. Therefore it is being renamed to
`[formField]`
thePunderWoman pushed a commit that referenced this pull request Jan 9, 2026
This completes the rename started in #66136. `[field]` is too generic of
a selector for the forms system to own, and likely to cause naming
collisions with existing components. Therefore it is being renamed to
`[formField]`
thePunderWoman pushed a commit that referenced this pull request Jan 9, 2026
This completes the rename started in #66136. `[field]` is too generic of
a selector for the forms system to own, and likely to cause naming
collisions with existing components. Therefore it is being renamed to
`[formField]`

(cherry picked from commit 5671f2c)
thePunderWoman pushed a commit that referenced this pull request Jan 9, 2026
This completes the rename started in #66136. `[field]` is too generic of
a selector for the forms system to own, and likely to cause naming
collisions with existing components. Therefore it is being renamed to
`[formField]`

(cherry picked from commit 5671f2c)
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: forms detected: feature PR contains a feature commit forms: signals merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants