fix(migrations): Do not remove a template if it is referenced with a trailing semicolon#64745
Merged
crisbeto merged 1 commit intoangular:mainfrom Oct 29, 2025
Merged
Conversation
atscott
approved these changes
Oct 28, 2025
78cd9b0 to
151b2b4
Compare
…th a trailing semilocon This commit fixes a behavior where under certain conditions, the migration script ignored a template reference with a trailing semicolon and incorrectly removed the definition of a referenced template. Fixes angular#64741
151b2b4 to
6e929e2
Compare
Member
lukasmatta
added a commit
to lukasmatta/angular
that referenced
this pull request
Nov 2, 2025
…ng whitespace characters In angular#64745, a fix was introduced for templates referenced with a trailing semicolon. However, templates are still incorrectly removed when there are whitespace characters before the template name. This commit updates the control flow migration logic to ensure templates referenced with preceding whitespace are not removed. Fixes angular#64741
lukasmatta
added a commit
to lukasmatta/angular
that referenced
this pull request
Nov 2, 2025
…ng whitespace characters In angular#64745, a fix was introduced for templates referenced with a trailing semicolon. However, templates are still incorrectly removed when there are whitespace characters before the template name. This commit updates the control flow migration logic to ensure templates referenced with preceding whitespace are not removed. Fixes angular#64854
atscott
pushed a commit
that referenced
this pull request
Nov 4, 2025
…ng whitespace characters In #64745, a fix was introduced for templates referenced with a trailing semicolon. However, templates are still incorrectly removed when there are whitespace characters before the template name. This commit updates the control flow migration logic to ensure templates referenced with preceding whitespace are not removed. Fixes #64854
atscott
pushed a commit
that referenced
this pull request
Nov 4, 2025
…ng whitespace characters In #64745, a fix was introduced for templates referenced with a trailing semicolon. However, templates are still incorrectly removed when there are whitespace characters before the template name. This commit updates the control flow migration logic to ensure templates referenced with preceding whitespace are not removed. Fixes #64854 (cherry picked from commit 5b210e9)
atscott
pushed a commit
that referenced
this pull request
Nov 4, 2025
…ng whitespace characters In #64745, a fix was introduced for templates referenced with a trailing semicolon. However, templates are still incorrectly removed when there are whitespace characters before the template name. This commit updates the control flow migration logic to ensure templates referenced with preceding whitespace are not removed. Fixes #64854 (cherry picked from commit 5b210e9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Under a specific condition described in #64741 the migration is wrongly removing a template that is used.
Issue Number: #64741
What is the new behavior?
It should not remove the template that is still used.
Does this PR introduce a breaking change?