fix(router): handle parenthesized outlets without a name in DefaultUr…#64507
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(router): handle parenthesized outlets without a name in DefaultUr…#64507atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
…lSerializer Previously, the `DefaultUrlSerializer` would incorrectly parse URLs with a parenthesized outlet that did not have a name, such as `/(left)`. This would result in an `undefined` outlet name in the serialized URL. This commit fixes the issue by ensuring that parenthesized outlets without a name are treated as primary outlets. fixes angular#58516. Based on the description, either the URL was constructed manually or by custom serializer.
7bcf1f8 to
8a9f233
Compare
JoostK
approved these changes
Oct 21, 2025
Member
crisbeto
pushed a commit
that referenced
this pull request
Oct 23, 2025
…lSerializer (#64507) Previously, the `DefaultUrlSerializer` would incorrectly parse URLs with a parenthesized outlet that did not have a name, such as `/(left)`. This would result in an `undefined` outlet name in the serialized URL. This commit fixes the issue by ensuring that parenthesized outlets without a name are treated as primary outlets. fixes #58516. Based on the description, either the URL was constructed manually or by custom serializer. PR Close #64507
crisbeto
pushed a commit
that referenced
this pull request
Oct 23, 2025
…lSerializer (#64507) Previously, the `DefaultUrlSerializer` would incorrectly parse URLs with a parenthesized outlet that did not have a name, such as `/(left)`. This would result in an `undefined` outlet name in the serialized URL. This commit fixes the issue by ensuring that parenthesized outlets without a name are treated as primary outlets. fixes #58516. Based on the description, either the URL was constructed manually or by custom serializer. PR Close #64507
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lSerializer
Previously, the
DefaultUrlSerializerwould incorrectly parse URLs with a parenthesized outlet that did not have a name, such as/(left). This would result in anundefinedoutlet name in the serialized URL.This commit fixes the issue by ensuring that parenthesized outlets without a name are treated as primary outlets.
fixes #58516. Based on the description, either the URL was constructed manually or by custom serializer.