Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 9, 2025

This is a patch port of #64253.

Now that the control flow migration is running as a part of ng update, we need to be a bit forgiving about there not being any matching files since it can break the entire update process.

These changes switch the error to a warning and it counts the files for the entire workspace, not the individual projects.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 9, 2025
@crisbeto crisbeto changed the title [Path port] fix(migrations): remove error for no matching files in control flow migration [Patch port] fix(migrations): remove error for no matching files in control flow migration Oct 9, 2025
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Oct 9, 2025
@ngbot ngbot bot added this to the Backlog milestone Oct 9, 2025
@JeanMeche
Copy link
Member

Shouldn't the PR target the 20.3.x branch ?

@crisbeto crisbeto changed the base branch from main to 20.3.x October 9, 2025 17:13
…igration (angular#64253)

Now that the control flow migration is running as a part of `ng update`, we need to be a bit forgiving about there not being any matching files since it can break the entire update process.

These changes switch the error to a warning and it counts the files for the entire workspace, not the individual projects.

PR Close angular#64253
@crisbeto crisbeto force-pushed the 20.2.x-control-flow-path branch from a81e136 to 4218b21 Compare October 9, 2025 17:14
@crisbeto
Copy link
Member Author

crisbeto commented Oct 9, 2025

Fixed.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

AndrewKushnir pushed a commit that referenced this pull request Oct 9, 2025
…igration (#64253) (#64314)

Now that the control flow migration is running as a part of `ng update`, we need to be a bit forgiving about there not being any matching files since it can break the entire update process.

These changes switch the error to a warning and it counts the files for the entire workspace, not the individual projects.

PR Close #64253

PR Close #64314
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants