Skip to content

refactor(core): add debug name to resource#64172

Closed
hawkgs wants to merge 3 commits intoangular:mainfrom
hawkgs:core/resource-debug-name
Closed

refactor(core): add debug name to resource#64172
hawkgs wants to merge 3 commits intoangular:mainfrom
hawkgs:core/resource-debug-name

Conversation

@hawkgs
Copy link
Copy Markdown
Member

@hawkgs hawkgs commented Oct 1, 2025

As part of the #63227 effort, this PR adds debugName support to resource and httpResource, and additionally implements a TS transform. The debug name has the following format:

Resource#{NAME}.${INTERNAL_SIGNAL_NAME}

Note that only the internal signals that are exposed to the signal graph have been decorated with a debugName.

Also, since the existing debugName transforms did not have tests, I've added some (although not completely exhaustive) that include the new changes as well.

@hawkgs hawkgs added area: core Issues related to the framework runtime area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 1, 2025
@ngbot ngbot bot added this to the Backlog milestone Oct 1, 2025
@pullapprove pullapprove bot requested a review from atscott October 1, 2025 13:19
JeanMeche
JeanMeche reviewed Oct 1, 2025
View reviewed changes
JeanMeche
JeanMeche reviewed Oct 1, 2025
View reviewed changes
JeanMeche
JeanMeche reviewed Oct 1, 2025
View reviewed changes
@hawkgs hawkgs mentioned this pull request Oct 2, 2025
Closed
14 tasks
@hawkgs hawkgs added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 3, 2025
JeanMeche
JeanMeche reviewed Oct 9, 2025
View reviewed changes
JeanMeche
JeanMeche reviewed Oct 9, 2025
View reviewed changes
@hawkgs hawkgs force-pushed the core/resource-debug-name branch 2 times, most recently from 73794af to 30efd07 Compare October 9, 2025 12:49
JeanMeche
JeanMeche reviewed Oct 9, 2025
View reviewed changes
JeanMeche
JeanMeche approved these changes Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the nit, I think we're good to go !

atscott
atscott approved these changes Oct 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-compiler, public-api

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 14, 2025
@hawkgs hawkgs added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 14, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Oct 14, 2025

This PR was merged into the repository. The changes were merged into the following branches:

AndrewKushnir pushed a commit that referenced this pull request Oct 14, 2025
@hawkgs @AndrewKushnir
refactor(compiler-cli): add a resource debugName transform (#64172)
e941e6b 
Add a TS transform for `resource` (and `httpResource`) `debugName`. Test the transformations.

PR Close #64172
AndrewKushnir pushed a commit that referenced this pull request Oct 14, 2025
@hawkgs @AndrewKushnir
refactor(core): add debug name to resource (#64172)
623c284 
Decorate `resource` (and `httpResource`) with `debugName`, along with all of its internal signals.

PR Close #64172
AndrewKushnir pushed a commit that referenced this pull request Oct 14, 2025
@hawkgs @AndrewKushnir
refactor(compiler-cli): add a resource debugName transform (#64172)
11b006e 
Add a TS transform for `resource` (and `httpResource`) `debugName`. Test the transformations.

PR Close #64172
@hawkgs hawkgs deleted the core/resource-debug-name branch October 14, 2025 18:32
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Oct 14, 2025
@AndrewKushnir
Revert "refactor(compiler-cli): add a resource debugName transform (a…
6eea893 
…ngular#64172)"

This reverts commit e941e6b.
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Oct 14, 2025
@AndrewKushnir
Revert "refactor(core): add debug name to resource (angular#64172)"
77a9652 
This reverts commit 6318006.
JeanMeche
JeanMeche reviewed Nov 4, 2025
View reviewed changes
@hawkgs hawkgs force-pushed the core/resource-debug-name branch from 3f3421f to 681e355 Compare November 4, 2025 15:12
@hawkgs hawkgs force-pushed the core/resource-debug-name branch from 681e355 to aacaf5f Compare November 4, 2025 16:39
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 11, 2025
@AndrewKushnir AndrewKushnir added action: global presubmit The PR is in need of a google3 global presubmit and removed action: merge The PR is ready for merge by the caretaker labels Nov 11, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Nov 11, 2025

FYI, this PR would need a TGP before we can land it, since it was reverted from g3 before due to breakages. @JeanMeche could you please help with running a TGP for this change?

@JeanMeche JeanMeche added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Nov 11, 2025
@JeanMeche
Copy link
Copy Markdown
Member

JeanMeche commented Nov 12, 2025

Currently deflaking the TGP.

We had a "green" one 9 days ago. I think this is safe to merge,

@hawkgs hawkgs linked an issue Nov 13, 2025 that may be closed by this pull request
DevTools signal visualization: Compound signals #63227
Closed
@hawkgs hawkgs added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate action: global presubmit The PR is in need of a google3 global presubmit labels Nov 20, 2025
@JeanMeche
Copy link
Copy Markdown
Member

JeanMeche commented Nov 20, 2025

The TGP is "green" (breakages seem unrelated).

@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Nov 24, 2025

This PR was merged into the repository. The changes were merged into the following branches:

kirjs pushed a commit that referenced this pull request Nov 24, 2025
@hawkgs @kirjs
refactor(core): add debug name to resource (#64172)
6de8926 
Decorate `resource` (and `httpResource`) with `debugName`, along with all of its internal signals.

PR Close #64172
kirjs pushed a commit that referenced this pull request Nov 24, 2025
@hawkgs @kirjs
refactor(compiler-cli): add a resource debugName transform (#64172)
9852033 
Add a TS transform for `resource` (and `httpResource`) `debugName`. Test the transformations.

PR Close #64172
@kirjs kirjs closed this in 3ae452e Nov 24, 2025
kirjs pushed a commit that referenced this pull request Nov 24, 2025
@hawkgs @kirjs
refactor(compiler-cli): add a resource debugName transform (#64172)
0f4b11c 
Add a TS transform for `resource` (and `httpResource`) `debugName`. Test the transformations.

PR Close #64172
@hawkgs hawkgs deleted the core/resource-debug-name branch November 24, 2025 17:38
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Dec 25, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2025
inesane pushed a commit to inesane/angular that referenced this pull request Mar 3, 2026
@hawkgs @inesane
refactor(core): add debug name to resource (angular#64172)
87828d3 
Decorate `resource` (and `httpResource`) with `debugName`, along with all of its internal signals.

PR Close angular#64172
inesane pushed a commit to inesane/angular that referenced this pull request Mar 3, 2026
@hawkgs @inesane
refactor(compiler-cli): add a resource debugName transform (angular#6…
94c0538 
…4172)

Add a TS transform for `resource` (and `httpResource`) `debugName`. Test the transformations.

PR Close angular#64172
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

DevTools signal visualization: Compound signals

6 participants

@hawkgs @AndrewKushnir @JeanMeche @kirjs @atscott @thePunderWoman