Skip to content

fix(migrations): handle shorthand property declarations in NgModule#64160

Closed
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx:fix/fixed-short-hand-module
Closed

fix(migrations): handle shorthand property declarations in NgModule#64160
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx:fix/fixed-short-hand-module

Conversation

@SkyZeroZx
Copy link
Copy Markdown
Contributor

@SkyZeroZx SkyZeroZx commented Sep 30, 2025 •
edited
Loading

The migration now correctly detects shorthand declarations in NgModule metadata

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #62787

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SkyZeroZx SkyZeroZx marked this pull request as ready for review September 30, 2025 18:38
@pullapprove pullapprove bot requested a review from JeanMeche September 30, 2025 18:38
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Sep 30, 2025
@ngbot ngbot bot added this to the Backlog milestone Sep 30, 2025
@SkyZeroZx
fix(migrations): handle shorthand property declarations in NgModule
c45418c 
The migration now correctly detects shorthand declarations in NgModule metadata
@SkyZeroZx SkyZeroZx force-pushed the fix/fixed-short-hand-module branch from 21b90a4 to c45418c Compare September 30, 2025 18:39
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 30, 2025
@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Oct 1, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@kirjs kirjs closed this in 51a0b59 Oct 1, 2025
kirjs pushed a commit that referenced this pull request Oct 1, 2025
@SkyZeroZx @kirjs
fix(migrations): handle shorthand property declarations in NgModule (#…
1710cbd 
…64160)

The migration now correctly detects shorthand declarations in NgModule metadata

PR Close #64160
napulitanfrontend pushed a commit to napulitanfrontend/angular that referenced this pull request Oct 10, 2025
@SkyZeroZx
fix(migrations): handle shorthand property declarations in NgModule (a…
52b9876 
…ngular#64160)

The migration now correctly detects shorthand declarations in NgModule metadata

PR Close angular#64160
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Nov 1, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@SkyZeroZx @kirjs @JeanMeche