fix(compiler): recover template literals with broken expressions#64150
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): recover template literals with broken expressions#64150crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Fixes two issues that were preventing template literals from being recovered properly if one of the interpolated expressions is broken: 1. We weren't updating the expected brace counter when an interpolation starts which in turn was throwing off the recovery logic in `skip`. 2. When producing tokens for template literals, we were treating the closing brace as an operator whereas other places treat it as a character. Even after fixing the first issue, this was preventing the recovery logic from working correctly. Fixes angular#63940.
atscott
approved these changes
Sep 30, 2025
Member
Author
Contributor
kirjs
pushed a commit
that referenced
this pull request
Sep 30, 2025
) Fixes two issues that were preventing template literals from being recovered properly if one of the interpolated expressions is broken: 1. We weren't updating the expected brace counter when an interpolation starts which in turn was throwing off the recovery logic in `skip`. 2. When producing tokens for template literals, we were treating the closing brace as an operator whereas other places treat it as a character. Even after fixing the first issue, this was preventing the recovery logic from working correctly. Fixes #63940. PR Close #64150
napulitanfrontend
pushed a commit
to napulitanfrontend/angular
that referenced
this pull request
Oct 10, 2025
…ular#64150) Fixes two issues that were preventing template literals from being recovered properly if one of the interpolated expressions is broken: 1. We weren't updating the expected brace counter when an interpolation starts which in turn was throwing off the recovery logic in `skip`. 2. When producing tokens for template literals, we were treating the closing brace as an operator whereas other places treat it as a character. Even after fixing the first issue, this was preventing the recovery logic from working correctly. Fixes angular#63940. PR Close angular#64150
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues that were preventing template literals from being recovered properly if one of the interpolated expressions is broken:
skip.Fixes #63940.