fix(migrations): handle reused templates in control flow migration#63996
Closed
aparzi wants to merge 1 commit intoangular:mainfrom
Closed
fix(migrations): handle reused templates in control flow migration#63996aparzi wants to merge 1 commit intoangular:mainfrom
aparzi wants to merge 1 commit intoangular:mainfrom
Conversation
c378836 to
9301b7f
Compare
JeanMeche
reviewed
Sep 22, 2025
packages/core/schematics/migrations/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Sep 22, 2025
packages/core/schematics/migrations/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
9301b7f to
434c0c9
Compare
JeanMeche
reviewed
Sep 23, 2025
packages/core/schematics/migrations/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
The control flow migration was incorrectly removing `ng-template` elements in scenarios where they were referenced by multiple `*ngIf` directives' `else` clauses and also used independently via `ngTemplateOutlet`.
434c0c9 to
244a4ac
Compare
JeanMeche
approved these changes
Sep 24, 2025
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control flow migration was incorrectly removing
ng-templateelements in scenarios where they were referenced by multiple*ngIfdirectives'elseclauses and also used independently viangTemplateOutlet.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Template:
After:
What is the new behavior?
This change updates the template processing logic to correctly detect all usages of a template, including property-bound
[ngTemplateOutlet]. The migration will now preserve theng-templateif it's still referenced after the*ngIfdirectives have been migrated.Now:
Does this PR introduce a breaking change?