fix(core): prevent animations renderer from impacting animate.leave#63921
Closed
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): prevent animations renderer from impacting animate.leave#63921thePunderWoman wants to merge 1 commit intoangular:mainfrom
animate.leave#63921thePunderWoman wants to merge 1 commit intoangular:mainfrom
Conversation
65dd7d2 to
b049593
Compare
f007b83 to
a6163eb
Compare
JeanMeche
reviewed
Sep 18, 2025
3fbabd1 to
8f2161a
Compare
4fa16a8 to
86c2b7d
Compare
AndrewKushnir
approved these changes
Sep 19, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM 👍
Can we also put together a test to reproduce the original issue to avoid regressions in the future?
86c2b7d to
99812cb
Compare
JeanMeche
approved these changes
Sep 19, 2025
This adds an optional flag to the renderer on `removeChild` called `requireSynchronousElementRemoval`, which can tell any downstream renderer that elements need to be removed synchronously. This gets passed down to the legacy animation renderer to ensure that any elements that set this flag aren't impacted by that renderers changes to timing. fixes: angular#63893
99812cb to
b3d1286
Compare
thePunderWoman
added a commit
that referenced
this pull request
Sep 19, 2025
…#63921) This adds an optional flag to the renderer on `removeChild` called `requireSynchronousElementRemoval`, which can tell any downstream renderer that elements need to be removed synchronously. This gets passed down to the legacy animation renderer to ensure that any elements that set this flag aren't impacted by that renderers changes to timing. fixes: #63893 PR Close #63921
Contributor
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bypasses the animation renderer when removing nodes that have
animate.leaveanimations. This is accomplished by exposing the root renderer via a newRenderer2function calledgetBaseRenderer(). For most renderers, this will just be the current renderer, but for the animations renderer, it will always get the root renderer.fixes: #63893