Skip to content

fix(compiler-cli): capture metadata for undecorated fields#63904

Closed
crisbeto wants to merge 3 commits intoangular:mainfrom
crisbeto:61229/signals-set-class-metadata
Closed

fix(compiler-cli): capture metadata for undecorated fields#63904
crisbeto wants to merge 3 commits intoangular:mainfrom
crisbeto:61229/signals-set-class-metadata

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Sep 18, 2025

Currently if TestBed.overrideComponent is used on a class that uses initializer APIs (e.g. input()), the initializer metadata will be wiped out, because overrideComponent re-compiles the class with the information set by setClassMetadata. setClassMetadata only captures decorated members at the moment.

These changes introduce some logic to capture the new initializer-based APIs in setClassMetadata as well.

Fixes #57944.

@crisbeto
refactor(compiler-cli): track member metadata using output AST
6eaca35 
Reworks the logic that tracks the decorator metadata for members to do so using the output AST, rather than wrapping the TypeScript AST. This makes it easier to programmatically generate new members that weren't part of the TypeScript AST before.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 18, 2025
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Sep 18, 2025
@ngbot ngbot Bot added this to the Backlog milestone Sep 18, 2025
@crisbeto
refactor(compiler): expose member decorator identifiers
49219a6 
Adds the member decorators to the map of exposed compiler symbols.
@crisbeto crisbeto force-pushed the 61229/signals-set-class-metadata branch from 68d7ead to 41bb4f3 Compare September 18, 2025 10:49
@crisbeto crisbeto requested a review from devversion September 18, 2025 11:03
@crisbeto crisbeto marked this pull request as ready for review September 18, 2025 11:03
devversion
devversion approved these changes Sep 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, non-blocking comments

Comment thread packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts Outdated
Comment thread packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts
* Returns a function that can be used to extract data for the `setClassMetadata`
* calls from undecorated directive class members.
*/
export function getDirectiveUndecoratedMetadataExtractor(
Copy link
Copy Markdown
Member

@devversion devversion Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could have built up this data synthetically afte all signal inputs, queries, model etc are known? Mostly my hope would be to avoid having to call these tryParseX methods again?

Did you also explore re-using some of the logic from the JIT transforms out of curiosity?

Copy link
Copy Markdown
Member Author

@crisbeto crisbeto Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The annoying part here is that it's dealing with the output AST, rather than JS data types or the TS AST. Originally I wanted to reuse the metadata we already have on inputs, but it ended up being easier to hook into the output AST construction instead.

@crisbeto crisbeto force-pushed the 61229/signals-set-class-metadata branch 2 times, most recently from 02aa8b8 to e22d5c1 Compare September 18, 2025 16:58
@crisbeto
fix(compiler-cli): capture metadata for undecorated fields
341e7d1 
Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment.

These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well.

Fixes angular#57944.
@crisbeto crisbeto force-pushed the 61229/signals-set-class-metadata branch from e22d5c1 to 341e7d1 Compare September 18, 2025 18:25
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 18, 2025
thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
@crisbeto @thePunderWoman
refactor(compiler-cli): track member metadata using output AST (#63904)
ba00432 
Reworks the logic that tracks the decorator metadata for members to do so using the output AST, rather than wrapping the TypeScript AST. This makes it easier to programmatically generate new members that weren't part of the TypeScript AST before.

PR Close #63904
thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
@crisbeto @thePunderWoman
refactor(compiler): expose member decorator identifiers (#63904)
a3094f2 
Adds the member decorators to the map of exposed compiler symbols.

PR Close #63904
thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
@crisbeto @thePunderWoman
fix(compiler-cli): capture metadata for undecorated fields (#63904)
ba40153 
Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment.

These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well.

Fixes #57944.

PR Close #63904
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Sep 18, 2025

This PR was merged into the repository. The changes were merged into the following branches:

thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
@crisbeto @thePunderWoman
refactor(compiler): expose member decorator identifiers (#63904)
ef0ff78 
Adds the member decorators to the map of exposed compiler symbols.

PR Close #63904
thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
@crisbeto @thePunderWoman
fix(compiler-cli): capture metadata for undecorated fields (#63904)
4c091ab 
Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment.

These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well.

Fixes #57944.

PR Close #63904
@JeanMeche JeanMeche mentioned this pull request Sep 19, 2025
Closed
thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Sep 19, 2025
@thePunderWoman
Revert "fix(compiler-cli): capture metadata for undecorated fields (a…
de4fad1 
…ngular#63904)"

This reverts commit 4c091ab.
thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Sep 19, 2025
@thePunderWoman
Revert "refactor(compiler): expose member decorator identifiers (angu…
d9883d0 
…lar#63904)"

This reverts commit ef0ff78.
thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Sep 19, 2025
@thePunderWoman
Revert "refactor(compiler-cli): track member metadata using output AST (
27aa2c8 
angular#63904)"

This reverts commit ffe94b3.
thePunderWoman added a commit that referenced this pull request Sep 19, 2025
@thePunderWoman
Revert "fix(compiler-cli): capture metadata for undecorated fields (#…
172e44b 
…63904)" (#63952)

This reverts commit 4c091ab.

PR Close #63952
thePunderWoman added a commit that referenced this pull request Sep 19, 2025
@thePunderWoman
Revert "refactor(compiler): expose member decorator identifiers (#63904…
720f0db 
…)" (#63952)

This reverts commit ef0ff78.

PR Close #63952
thePunderWoman added a commit that referenced this pull request Sep 19, 2025
@thePunderWoman
Revert "refactor(compiler-cli): track member metadata using output AST (
8858e3c 
#63904)" (#63952)

This reverts commit ffe94b3.

PR Close #63952
thePunderWoman added a commit that referenced this pull request Sep 19, 2025
@thePunderWoman
Revert "fix(compiler-cli): capture metadata for undecorated fields (#…
9d3cd16 
…63904)" (#63952)

This reverts commit 4c091ab.

PR Close #63952
thePunderWoman added a commit that referenced this pull request Sep 19, 2025
@thePunderWoman
Revert "refactor(compiler): expose member decorator identifiers (#63904…
5d538b2 
…)" (#63952)

This reverts commit ef0ff78.

PR Close #63952
thePunderWoman added a commit that referenced this pull request Sep 19, 2025
@thePunderWoman
Revert "refactor(compiler-cli): track member metadata using output AST (
2d232b3 
#63904)" (#63952)

This reverts commit ffe94b3.

PR Close #63952
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Sep 19, 2025

@crisbeto We had to revert this due to a test breakage in G3.

@thePunderWoman thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews requires: TGP This PR requires a passing TGP before merging is allowed and removed action: merge The PR is ready for merge by the caretaker labels Sep 19, 2025
@pullapprove pullapprove Bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Sep 19, 2025
@JeanMeche JeanMeche added the action: global presubmit The PR is in need of a google3 global presubmit label Sep 19, 2025
@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented Sep 19, 2025

Will open a new PR.

@crisbeto crisbeto closed this Sep 19, 2025
@crisbeto crisbeto mentioned this pull request Sep 19, 2025
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Oct 20, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: global presubmit The PR is in need of a google3 global presubmit area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Initializer APIs (input, output, queries) not integrating with TestBed.override in a jit & aot mix

4 participants

@crisbeto @thePunderWoman @devversion @JeanMeche