fix(compiler-cli): capture metadata for undecorated fields #63904
+466
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks the logic that tracks the decorator metadata for members to do so using the output AST, rather than wrapping the TypeScript AST. This makes it easier to programmatically generate new members that weren't part of the TypeScript AST before.
Adds the member decorators to the map of exposed compiler symbols.
68d7ead to
41bb4f3
Compare
devversion
approved these changes
Sep 18, 2025
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM, non-blocking comments
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts
Outdated
Show resolved
Hide resolved
| * Returns a function that can be used to extract data for the `setClassMetadata` | ||
| * calls from undecorated directive class members. | ||
| */ | ||
| export function getDirectiveUndecoratedMetadataExtractor( |
Member
There was a problem hiding this comment.
I wonder if we could have built up this data synthetically afte all signal inputs, queries, model etc are known? Mostly my hope would be to avoid having to call these tryParseX methods again?
Did you also explore re-using some of the logic from the JIT transforms out of curiosity?
Member
Author
There was a problem hiding this comment.
The annoying part here is that it's dealing with the output AST, rather than JS data types or the TS AST. Originally I wanted to reuse the metadata we already have on inputs, but it ended up being easier to hook into the output AST construction instead.
02aa8b8 to
e22d5c1
Compare
Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment. These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well. Fixes angular#57944.
e22d5c1 to
341e7d1
Compare
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 18, 2025
Reworks the logic that tracks the decorator metadata for members to do so using the output AST, rather than wrapping the TypeScript AST. This makes it easier to programmatically generate new members that weren't part of the TypeScript AST before. PR Close #63904
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 18, 2025
Adds the member decorators to the map of exposed compiler symbols. PR Close #63904
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 18, 2025
Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment. These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well. Fixes #57944. PR Close #63904
Contributor
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 18, 2025
Adds the member decorators to the map of exposed compiler symbols. PR Close #63904
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 18, 2025
Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment. These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well. Fixes #57944. PR Close #63904
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Sep 19, 2025
…ngular#63904)" This reverts commit 4c091ab.
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Sep 19, 2025
…lar#63904)" This reverts commit ef0ff78.
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Sep 19, 2025
angular#63904)" This reverts commit ffe94b3.
thePunderWoman
added a commit
that referenced
this pull request
Sep 19, 2025
thePunderWoman
added a commit
that referenced
this pull request
Sep 19, 2025
thePunderWoman
added a commit
that referenced
this pull request
Sep 19, 2025
thePunderWoman
added a commit
that referenced
this pull request
Sep 19, 2025
thePunderWoman
added a commit
that referenced
this pull request
Sep 19, 2025
thePunderWoman
added a commit
that referenced
this pull request
Sep 19, 2025
Contributor
|
@crisbeto We had to revert this due to a test breakage in G3. |
Member
Author
|
Will open a new PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
TestBed.overrideComponentis used on a class that uses initializer APIs (e.g.input()), the initializer metadata will be wiped out, becauseoverrideComponentre-compiles the class with the information set bysetClassMetadata.setClassMetadataonly captures decorated members at the moment.These changes introduce some logic to capture the new initializer-based APIs in
setClassMetadataas well.Fixes #57944.