refactor(compiler-cli): Add a diagnostic to detect forbiden invocations of required initializers#63614
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(compiler-cli): Add a diagnostic to detect forbiden invocations of required initializers#63614JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
39b48d2 to
4463875
Compare
382e68f to
85a296c
Compare
Member
Author
|
TGP is "green" |
tienthanhjlw
approved these changes
Sep 7, 2025
crisbeto
reviewed
Sep 8, 2025
...ages/compiler-cli/src/ngtsc/validation/src/rules/forbidden_required_input_invokation_rule.ts
Outdated
Show resolved
Hide resolved
...ages/compiler-cli/src/ngtsc/validation/src/rules/forbidden_required_input_invokation_rule.ts
Outdated
Show resolved
Hide resolved
...ages/compiler-cli/src/ngtsc/validation/src/rules/forbidden_required_input_invokation_rule.ts
Outdated
Show resolved
Hide resolved
...ages/compiler-cli/src/ngtsc/validation/src/rules/forbidden_required_input_invokation_rule.ts
Outdated
Show resolved
Hide resolved
...ages/compiler-cli/src/ngtsc/validation/src/rules/forbidden_required_input_invokation_rule.ts
Outdated
Show resolved
Hide resolved
85a296c to
cb8d3c3
Compare
cfef607 to
387ecaf
Compare
crisbeto
approved these changes
Sep 9, 2025
crisbeto
approved these changes
Sep 9, 2025
crisbeto
approved these changes
Sep 9, 2025
eneajaho
reviewed
Sep 9, 2025
mmalerba
approved these changes
Sep 12, 2025
Contributor
mmalerba
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
387ecaf to
0d59ad6
Compare
Member
Author
|
There is 1 cleanup that still needs to land in g3. |
…ns of required initializers The diagnostic will raise an error when required initializers (input, model, queries) are invoked the context of property initializers and contructors. Docs will be provided in a follow-up fixes angular#63602
0d59ad6 to
fd15cef
Compare
Contributor
wildcardalice
pushed a commit
to wildcardalice/angular
that referenced
this pull request
Sep 18, 2025
…ns of required initializers (angular#63614) The diagnostic will raise an error when required initializers (input, model, queries) are invoked the context of property initializers and contructors. Docs will be provided in a follow-up fixes angular#63602 PR Close angular#63614
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diagnostic will raise an error when required initializers (input, model, queries) are invoked the context of property initializers and contructors.
Docs will be provided in a follow-up
fixes #63602