refactor(common): trim undefined from locale data.#63520
refactor(common): trim undefined from locale data.#63520JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
|
@devversion I found this issue of your and went with it. |
6a79916 to
a445cfe
Compare
devversion
left a comment
There was a problem hiding this comment.
Did you verify that functions relying on this data are "good"? do we have tests?
| * e.g.: [x, y, undefined, z, undefined, undefined] will be [x, y, u, z, u, u] | ||
| * | ||
| * In some cases, we also trim the trailing `undefined` values in the array, as they | ||
| * don't add any information. We don't always want to do it as sometimes returned array is destructued. |
There was a problem hiding this comment.
| * don't add any information. We don't always want to do it as sometimes returned array is destructued. | |
| * don't add any information. We don't always want to do it as sometimes returned array is destructured. |
There was a problem hiding this comment.
I did some visual checks by diffing the files and also we have some tests in packages/common/test/i18n that load the locale data (and test the localized outputs)
This is an optimization to shave of unecessary data. fixes angular#42315
a445cfe to
b858c79
Compare
This is an optimization to shave of unecessary data. fixes angular#42315 PR Close angular#63520
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is an optimization to shave off unecessary data.
fixes #42315