Skip to content

feat(core): Add QueryList#forEach #6341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lacolaco wants to merge 2 commits into from
Closed

feat(core): Add QueryList#forEach #6341

lacolaco wants to merge 2 commits into from

Conversation

@lacolaco
Copy link
Contributor

@lacolaco lacolaco commented Jan 8, 2016

Add forEach to QueryList.

Close #6314

@lacolaco lacolaco force-pushed the laco-querylist-foreach branch from 8c3a6f4 to 19741dd Compare January 11, 2016 05:41
@jelbourn jelbourn added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 1, 2016
@jelbourn
Copy link
Member

jelbourn commented Feb 1, 2016

@vsavkin please review

@vsavkin vsavkin added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 4, 2016
@vsavkin vsavkin removed their assignment Feb 4, 2016
@jelbourn jelbourn assigned vsavkin and unassigned vsavkin Feb 8, 2016
@mary-poppins
Copy link

mary-poppins commented Feb 10, 2016

Merging PR #6341 on behalf of @btford to branch presubmit-btford-pr-6341.

@btford
Copy link
Contributor

btford commented Feb 10, 2016

After rebasing, this fails: https://travis-ci.org/angular/angular/jobs/108405209#L1029-L1045

Looks like it should be added to the core API somewhere. @vsavkin can you please help @laco0416 make this change?

@vsavkin
Copy link
Contributor

vsavkin commented Feb 11, 2016

@laco0416 could you modify public_api_guard/public_api_spec.js and add QueryList.forEach(fn:(item: T) => void):void to CORE. You can run:

gulp build.js.cjs
gulp check-public-api

to check that it works.

@lacolaco
Copy link
Contributor Author

lacolaco commented Feb 11, 2016

@vsavkin Thank you! I try to do it soon.

@lacolaco lacolaco force-pushed the laco-querylist-foreach branch from 19741dd to ef22fd4 Compare February 11, 2016 00:53
@lacolaco
Copy link
Contributor Author

lacolaco commented Feb 11, 2016

@btford @vsavkin I've fixed it!

@zoechi zoechi mentioned this pull request Feb 12, 2016
Closed
@mary-poppins
Copy link

mary-poppins commented Feb 17, 2016

Merging PR #6341 on behalf of @btford to branch presubmit-btford-pr-6341.

@matsko
Copy link
Contributor

matsko commented Feb 20, 2016

Landed as e7470d5

@matsko matsko closed this Feb 20, 2016
@lacolaco
Copy link
Contributor Author

lacolaco commented Feb 20, 2016

Thanks all!

@lacolaco lacolaco deleted the laco-querylist-foreach branch February 20, 2016 00:36
@zoechi zoechi mentioned this pull request Mar 23, 2016
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add forEach to QueryList

7 participants

@lacolaco @jelbourn @mary-poppins @btford @vsavkin @matsko @googlebot