refactor(core): replace Optional/SkipSelf deps with inject() flags#63386
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): replace Optional/SkipSelf deps with inject() flags#63386arturovt wants to merge 1 commit intoangular:mainfrom
arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
This commit updates provider definitions that relied on the `deps` array
with `new Optional()` and `new SkipSelf()` to instead use the modern
`inject(..., { optional: true, skipSelf: true })` API.
Previously:
deps: [[KeyValueDiffers, new SkipSelf(), new Optional()]]
Now:
const parent = inject(KeyValueDiffers, { optional: true, skipSelf: true });
**Bundle size reduction**: `Optional` and `SkipSelf` are runtime values
created by `makeParamDecorator()`. Even in production builds, esbuild
and other bundlers must keep their factory code because they are
referenced with `new Optional()` / `new SkipSelf()`. With `inject()`,
those classes are no longer referenced, allowing them and the
`makeParamDecorator` scaffolding to be tree-shaken when unused.
As a result, production bundles can drop both `Optional`, `SkipSelf`, and
their supporting factory code when not used elsewhere, reducing code size
while keeping the same behavior.
JeanMeche
approved these changes
Aug 26, 2025
Contributor
mmalerba
pushed a commit
that referenced
this pull request
Aug 28, 2025
…63386) This commit updates provider definitions that relied on the `deps` array with `new Optional()` and `new SkipSelf()` to instead use the modern `inject(..., { optional: true, skipSelf: true })` API. Previously: deps: [[KeyValueDiffers, new SkipSelf(), new Optional()]] Now: const parent = inject(KeyValueDiffers, { optional: true, skipSelf: true }); **Bundle size reduction**: `Optional` and `SkipSelf` are runtime values created by `makeParamDecorator()`. Even in production builds, esbuild and other bundlers must keep their factory code because they are referenced with `new Optional()` / `new SkipSelf()`. With `inject()`, those classes are no longer referenced, allowing them and the `makeParamDecorator` scaffolding to be tree-shaken when unused. As a result, production bundles can drop both `Optional`, `SkipSelf`, and their supporting factory code when not used elsewhere, reducing code size while keeping the same behavior. PR Close #63386
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates provider definitions that relied on the
depsarray withnew Optional()andnew SkipSelf()to instead use the moderninject(..., { optional: true, skipSelf: true })API.Previously:
deps: [[KeyValueDiffers, new SkipSelf(), new Optional()]]Now:
const parent = inject(KeyValueDiffers, { optional: true, skipSelf: true });Bundle size reduction:
OptionalandSkipSelfare runtime values created bymakeParamDecorator(). Even in production builds, esbuild and other bundlers must keep their factory code because they are referenced withnew Optional()/new SkipSelf(). Withinject(), those classes are no longer referenced, allowing them and themakeParamDecoratorscaffolding to be tree-shaken when unused.As a result, production bundles can drop both
Optional,SkipSelf, and their supporting factory code when not used elsewhere, reducing code size while keeping the same behavior.