Skip to content

docs: animationsEnabled defaults to false#63262

Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat:fix/animations-enabled
Closed

docs: animationsEnabled defaults to false#63262
cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat:fix/animations-enabled

Conversation

@cexbrayat
Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

The animationsEnabled option of the testBed defaults to false but its docs said otherwise.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from atscott August 20, 2025 07:20
@angular-robot angular-robot bot added the area: docs Related to the documentation label Aug 20, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 20, 2025
@JeanMeche JeanMeche requested review from thePunderWoman and removed request for atscott August 20, 2025 07:29
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for this. Forgot to update this when we switched it from animationsDisabled to animationsEnabled.

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 20, 2025
@thePunderWoman
Copy link
Copy Markdown
Contributor

Caretaker note: this is docs only and does not need a presubmit

@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit bf9db28.

The changes were merged into the following branches: main, 20.2.x

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants