refactor(core): improve animation instruction robustness and maintainability#63163
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): improve animation instruction robustness and maintainability#63163cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
reviewed
Aug 15, 2025
ecdba3f to
9fc713b
Compare
9fc713b to
9fc9201
Compare
thePunderWoman
requested changes
Aug 18, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
Thanks for this cleanup. Other than the one change, I think this looks good.
…ability This commit extracts helper functions to reduce code duplication across animation instructions and adds early return when animations are disabled.
9fc9201 to
384c837
Compare
Member
|
This PR was merged into the repository by commit e9b2fe7. The changes were merged into the following branches: main, 20.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some early returns are missing in animation instructions, and some others can be moved earlier in the function to improve performance when animations are disabled.
What is the new behavior?
This commit extracts helper functions to reduce code duplication across animation instructions and adds early return when animations are disabled.
Does this PR introduce a breaking change?
Other information