fix(compiler-cli): correctly type check host listeners to own outputs#62965
Closed
crisbeto wants to merge 2 commits intoangular:mainfrom
Closed
fix(compiler-cli): correctly type check host listeners to own outputs#62965crisbeto wants to merge 2 commits intoangular:mainfrom
crisbeto wants to merge 2 commits intoangular:mainfrom
Conversation
Allows the target binder to resolve directives set on the host element.
eb76682 to
49fd593
Compare
49fd593 to
dfcca8f
Compare
Currently the code that type checks host bindings assumes that all listeners are bound to the DOM, however that's not the case since host bindings can also bind to own outputs. These changes update the TCB to generate the proper code for type checking such outputs. Fixes angular#62783.
dfcca8f to
35f1f18
Compare
JoostK
approved these changes
Aug 4, 2025
Member
Author
|
This PR was merged into the repository by commit fb1fc82. The changes were merged into the following branches: main, 20.1.x |
crisbeto
added a commit
that referenced
this pull request
Aug 5, 2025
…#62965) Currently the code that type checks host bindings assumes that all listeners are bound to the DOM, however that's not the case since host bindings can also bind to own outputs. These changes update the TCB to generate the proper code for type checking such outputs. Fixes #62783. PR Close #62965
crisbeto
added a commit
that referenced
this pull request
Aug 5, 2025
…#62965) Currently the code that type checks host bindings assumes that all listeners are bound to the DOM, however that's not the case since host bindings can also bind to own outputs. These changes update the TCB to generate the proper code for type checking such outputs. Fixes #62783. PR Close #62965
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the code that type checks host bindings assumes that all listeners are bound to the DOM, however that's not the case since host bindings can also bind to own outputs.
These changes update the TCB to generate the proper code for type checking such outputs.
Fixes #62783.