refactor(animations): optimize resolveTimeExpression#62927
Closed
amilajack wants to merge 3 commits intoangular:mainfrom
Closed
refactor(animations): optimize resolveTimeExpression#62927amilajack wants to merge 3 commits intoangular:mainfrom
amilajack wants to merge 3 commits intoangular:mainfrom
Conversation
devversion
approved these changes
Aug 5, 2025
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM, but can you please fix the commit message?
Contributor
Author
|
updated the pr title and commit msg |
This moves a regexp expression into a const to optimize performance.
Member
|
This PR was merged into the repository by commit ec8cd3e. The changes were merged into the following branches: main, 20.1.x |
crisbeto
pushed a commit
that referenced
this pull request
Aug 6, 2025
This moves a regexp expression into a const to optimize performance. PR Close #62927
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
n/a
Does this PR introduce a breaking change?
Other information
From our profiling data, we see
cloakAndComputeStylesindirectly invokesparseTimeExpressionin a loop, making it a hot path in our app. This is a pass at optimizing it.