Skip to content

misc macro refactoring#62878

Closed
josephperrott wants to merge 3 commits intoangular:mainfrom
josephperrott:migrate-final-nodejs_binary
Closed

misc macro refactoring#62878
josephperrott wants to merge 3 commits intoangular:mainfrom
josephperrott:migrate-final-nodejs_binary

Conversation

@josephperrott
Copy link
Copy Markdown
Member

No description provided.

Remove the remaining usages of our nodejs_binary macros
Remove unused npm_package_bin macro
Move http_server and generate_api_docs into defaults2.bzl as they are rules_js compliant
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Jul 29, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 29, 2025
@angular-robot angular-robot bot removed the action: merge The PR is ready for merge by the caretaker label Jul 29, 2025
@josephperrott josephperrott marked this pull request as ready for review July 29, 2025 15:44
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jul 29, 2025
@pullapprove pullapprove bot requested a review from thePunderWoman July 29, 2025 15:44
thePunderWoman pushed a commit that referenced this pull request Jul 29, 2025
Remove the remaining usages of our nodejs_binary macros

PR Close #62878
thePunderWoman pushed a commit that referenced this pull request Jul 29, 2025
Remove unused npm_package_bin macro

PR Close #62878
thePunderWoman pushed a commit that referenced this pull request Jul 29, 2025
)

Move http_server and generate_api_docs into defaults2.bzl as they are rules_js compliant

PR Close #62878
thePunderWoman pushed a commit that referenced this pull request Jul 29, 2025
Remove unused npm_package_bin macro

PR Close #62878
thePunderWoman pushed a commit that referenced this pull request Jul 29, 2025
)

Move http_server and generate_api_docs into defaults2.bzl as they are rules_js compliant

PR Close #62878
@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 793ff35.

The changes were merged into the following branches: main, 20.1.x

@josephperrott josephperrott deleted the migrate-final-nodejs_binary branch July 29, 2025 17:14
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants