Skip to content

refactor(common): removengModuleFactory input of NgComponentOutlet#62838

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:common/component-outlet-module-factory
Closed

refactor(common): removengModuleFactory input of NgComponentOutlet#62838
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:common/component-outlet-module-factory

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

This was deprecated by #44815

BREAKING CHANGE: NgModuleFactory has been removed, use NgModule instead.

@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change area: common Issues related to APIs in the @angular/common package labels Jul 27, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 27, 2025
@JeanMeche JeanMeche modified the milestones: Backlog, v21 Candidate Jul 27, 2025
@JeanMeche
Copy link
Copy Markdown
Member Author

JeanMeche commented Jul 27, 2025

G3 already had no usages. Passing TGP.

@JeanMeche JeanMeche marked this pull request as ready for review August 13, 2025 22:40
@pullapprove pullapprove bot requested a review from atscott August 13, 2025 22:40
@JeanMeche JeanMeche added the target: major This PR is targeted for the next major release label Aug 13, 2025
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Yay removals!

reviewed-for: fw-general, public-api

@pullapprove pullapprove bot requested review from crisbeto and kirjs August 18, 2025 09:41
Copy link
Copy Markdown
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

This was deprecated by angular#44815

BREAKING CHANGE: NgModuleFactory has been removed, use NgModule instead.
@JeanMeche JeanMeche force-pushed the common/component-outlet-module-factory branch from 85c4bcf to 4907676 Compare August 20, 2025 12:19
@JeanMeche JeanMeche removed request for atscott and kirjs August 20, 2025 13:10
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Aug 20, 2025
@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 25f593c.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package breaking changes detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants