feat(common): support NgModule as an input to the NgComponentOutlet#44815
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
feat(common): support NgModule as an input to the NgComponentOutlet#44815AndrewKushnir wants to merge 1 commit intoangular:masterfrom
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Conversation
5da09d5 to
36fcbef
Compare
9cd4d66 to
c80e0ad
Compare
Contributor
Author
c80e0ad to
5bdf7fd
Compare
alxhub
approved these changes
Jan 31, 2022
atscott
approved these changes
Jan 31, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
This commit updates the logic of the `NgComponentOutlet` class to allow passing an `NgModule` as an input instead of passing an `NgModule` factory. DEPRECATED: The `ngModuleFactory` input of the `NgComponentOutlet` directive is deprecated in favor of a newly added `ngModule` input. The `ngModule` input accepts references to the NgModule class directly, without the need to resolve module factory first.
5bdf7fd to
b202dff
Compare
jessicajaniuk
approved these changes
Feb 1, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM 🍪
reviewed-for: public-api
dylhunn
approved these changes
Feb 1, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit c89cf63. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
…ngular#44815) This commit updates the logic of the `NgComponentOutlet` class to allow passing an `NgModule` as an input instead of passing an `NgModule` factory. DEPRECATED: The `ngModuleFactory` input of the `NgComponentOutlet` directive is deprecated in favor of a newly added `ngModule` input. The `ngModule` input accepts references to the NgModule class directly, without the need to resolve module factory first. PR Close angular#44815
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the logic of the
NgComponentOutletclass to allow passing anNgModuleas an input instead of passing NgModule factory.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?