Skip to content

build: use rollup directory instead of rollup through @bazel/rollup#62556

Closed
josephperrott wants to merge 1 commit intoangular:mainfrom
josephperrott:migrate-rollup
Closed

build: use rollup directory instead of rollup through @bazel/rollup#62556
josephperrott wants to merge 1 commit intoangular:mainfrom
josephperrott:migrate-rollup

Conversation

@josephperrott
Copy link
Copy Markdown
Member

@josephperrott josephperrott commented Jul 9, 2025

No description provided.

@josephperrott josephperrott requested a review from devversion July 9, 2025 18:34
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate PullApprove: disable labels Jul 9, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 9, 2025
devversion
devversion approved these changes Jul 9, 2025
View reviewed changes
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Jul 9, 2025
@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist bot commented Jul 9, 2025

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jul 9, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Jul 9, 2025

Looks like there are legit CI failures, adding the "cleanup" label for now.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker labels Jul 9, 2025
@josephperrott
build: use rollup directory instead of rollup through @bazel/rollup
11ee78c 
Use rollup directly instead of using the previous toolchain implementation
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jul 9, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Jul 9, 2025

This PR was merged into the repository by commit efc2a41.

The changes were merged into the following branches: main, 20.1.x

AndrewKushnir pushed a commit that referenced this pull request Jul 9, 2025
@josephperrott @AndrewKushnir
build: use rollup directory instead of rollup through @bazel/rollup (#…
b4ae55a 
…62556)

Use rollup directly instead of using the previous toolchain implementation

PR Close #62556
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Aug 12, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@josephperrott @AndrewKushnir @devversion