refactor(migrations): ensure tsurge can properly emit references in g3#62447
Closed
devversion wants to merge 1 commit intoangular:mainfrom
Closed
refactor(migrations): ensure tsurge can properly emit references in g3#62447devversion wants to merge 1 commit intoangular:mainfrom
devversion wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
approved these changes
Jul 3, 2025
Currently when Tsurge runs in g3, it creates a bare bones Angular compiler plugin. The tsconfigs from compilation units may set options like "useHostForImportGeneration", but the Ngtsc logic doesn't enable because the `fileNameToModuleName` method is not defined on the host. This can break reference emission for Tsurge analyzers/programs and result in subtle differences to real `ng_module` compilations. This commit fixes this by making the method available in 1P Tsurge. Notably, reference emission can occur during analysis— so even if migrations aren't "emitting TS -> JS" output.
3b083ba to
49b9551
Compare
This comment was marked as outdated.
This comment was marked as outdated.
thePunderWoman
pushed a commit
that referenced
this pull request
Jul 3, 2025
#62447) Currently when Tsurge runs in g3, it creates a bare bones Angular compiler plugin. The tsconfigs from compilation units may set options like "useHostForImportGeneration", but the Ngtsc logic doesn't enable because the `fileNameToModuleName` method is not defined on the host. This can break reference emission for Tsurge analyzers/programs and result in subtle differences to real `ng_module` compilations. This commit fixes this by making the method available in 1P Tsurge. Notably, reference emission can occur during analysis— so even if migrations aren't "emitting TS -> JS" output. PR Close #62447
thePunderWoman
pushed a commit
that referenced
this pull request
Jul 3, 2025
#62447) Currently when Tsurge runs in g3, it creates a bare bones Angular compiler plugin. The tsconfigs from compilation units may set options like "useHostForImportGeneration", but the Ngtsc logic doesn't enable because the `fileNameToModuleName` method is not defined on the host. This can break reference emission for Tsurge analyzers/programs and result in subtle differences to real `ng_module` compilations. This commit fixes this by making the method available in 1P Tsurge. Notably, reference emission can occur during analysis— so even if migrations aren't "emitting TS -> JS" output. PR Close #62447
Contributor
|
This PR was merged into the repository by commit 902121e. The changes were merged into the following branches: main, 20.0.x, 20.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when Tsurge runs in g3, it creates a bare bones Angular compiler plugin. The tsconfigs from compilation units may set options like "useHostForImportGeneration", but the Ngtsc logic doesn't enable because the
fileNameToModuleNamemethod is not defined on the host.This can break reference emission for Tsurge analyzers/programs and result in subtle differences to real
ng_modulecompilations. This commit fixes this by making the method available in 1P Tsurge.Notably, reference emission can occur during analysis— so even if migrations aren't "emitting TS -> JS" output.