Skip to content

fix(migrations): more robust trailing comma removal in unused imports migration #62118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

fix(migrations): more robust trailing comma removal in unused imports migration #62118

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 18, 2025

Fixes the following issues with the logic in the unused imports migration that deals with trailing commas:

  1. It was generating overlapping text ranges which can break internally.
  2. It wasn't handling some cases that produce trailing commas.

@crisbeto
fix(migrations): more robust trailing comma removal in unused imports…
909fd6d 
… migration

Fixes the following issues with the logic in the unused imports migration that deals with trailing commas:
1. It was generating overlapping text ranges which can break internally.
2. It wasn't handling some cases that produce trailing commas.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 18, 2025
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Jun 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 18, 2025
@crisbeto crisbeto marked this pull request as ready for review June 18, 2025 13:20
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 18, 2025
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Jun 18, 2025

This PR was merged into the repository by commit 34adfde.

The changes were merged into the following branches: main, 20.0.x

pkozlowski-opensource pushed a commit that referenced this pull request Jun 18, 2025
@crisbeto @pkozlowski-opensource
fix(migrations): more robust trailing comma removal in unused imports…
82bf984 
… migration (#62118)

Fixes the following issues with the logic in the unused imports migration that deals with trailing commas:
1. It was generating overlapping text ranges which can break internally.
2. It wasn't handling some cases that produce trailing commas.

PR Close #62118
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 19, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @pkozlowski-opensource