refactor(core): update FakeNavigation to the latest spec#62017
Closed
atscott wants to merge 2 commits into
Closed
Conversation
45e41dd to
63e7890
Compare
tbondwilkinson
approved these changes
Jun 11, 2025
Contributor
|
TESTED=TGP |
63e7890 to
dd97d49
Compare
Member
|
Looks like it needs rebase so moving it from merge => cleanup |
Spec updates are in whatwg/html#10919 For the most part, the updates revolve around the deferred commit handling (with precommitHandler). Updates to redirect allow more options. A committed promise now exists on the transition since commits can be delayed. Tests were made zoneless for easier debugging and timeouts were reduced.
acca5ca to
fc14fc2
Compare
fc14fc2 to
1a49d06
Compare
Member
|
I'll proceed with merging this. The adev test failure looks unrelated. |
Member
|
This PR was merged into the repository by commit fa5ae92. The changes were merged into the following branches: main, 20.0.x |
crisbeto
pushed a commit
that referenced
this pull request
Jun 19, 2025
Spec updates are in whatwg/html#10919 For the most part, the updates revolve around the deferred commit handling (with precommitHandler). Updates to redirect allow more options. A committed promise now exists on the transition since commits can be delayed. Tests were made zoneless for easier debugging and timeouts were reduced. PR Close #62017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec updates are in whatwg/html#10919
For the most part, the updates revolve around the deferred commit handling (with precommitHandler). Updates to redirect allow more options. A committed promise now exists on the transition since commits can be delayed. Tests were made zoneless for easier debugging and timeouts were reduced.