refactor(core): Delete createSignalTuple#61907
Closed
tsc036 wants to merge 1 commit intoangular:mainfrom
Closed
Conversation
Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior.
mturco
approved these changes
Jun 5, 2025
Contributor
mturco
left a comment
There was a problem hiding this comment.
Reviewed-for: primitives-shared
thePunderWoman
approved these changes
Jun 6, 2025
Contributor
|
TESTED=TGP |
Contributor
|
TGP is green |
pkozlowski-opensource
approved these changes
Jun 6, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-general
Reviewed-for: public-api
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jun 6, 2025
Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior. PR Close #61907
Member
|
This PR was merged into the repository by commit 6097184. The changes were merged into the following branches: main, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
It removes createSignalTuple because it is no longer needed.
What is the current behavior?
createSignalTuple was a deprecated API
Issue Number: N/A
What is the new behavior?
createSignalTuple is removed
Does this PR introduce a breaking change?
Other information