Skip to content

[20.0.x]: Patch port of #61843, and #61826#61862

Closed
devversion wants to merge 10 commits intoangular:20.0.xfrom
devversion:rjs-7-patch
Closed

[20.0.x]: Patch port of #61843, and #61826#61862
devversion wants to merge 10 commits intoangular:20.0.xfrom
devversion:rjs-7-patch

Conversation

@devversion
Copy link
Copy Markdown
Member

Patch port of #61843, and #61826

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 4, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 4, 2025
@devversion devversion requested a review from josephperrott June 4, 2025 13:17
@devversion devversion added target: patch This PR is targeted for the next patch release PullApprove: disable labels Jun 4, 2025
@devversion devversion marked this pull request as ready for review June 4, 2025 13:17
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2025
@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Jun 4, 2025

Please rebase this PR

@devversion
Copy link
Copy Markdown
Member Author

Rebased but this got conflicted again. I will merge myself tomorrow morning.

@JeanMeche JeanMeche added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jun 4, 2025
devversion and others added 10 commits June 5, 2025 06:54
This commit migrates the remaining pieces of `compiler-cli` to
`ts_project`. This involves a few more things during migration:

- the `ng_module` ngc_wrapped rule broke as part of this change, so we
  switched it to `ts_project` too. This logic is soon gone anyway.

- we needed an extra pnpm "package.json" for the linker babel test. This test is
  loading from the real compiler-cli npm package. Babel needs a real
  node module for this, so this solution seems reasonable. It may be
  worth exploring in the future to move this test into an integration
  test though.

- the older integrationtest in compiler-cli is removed as the coverage
  is much better with the compliance test suite and this test.
The bazel npm package is no longer needed and currently breaks
as we started using a 1P pnpm linked package that would otherwise
end up being pulled into this legacy rule.
Migrates remaining `ts_project` targets (excluding zone.js) to
`ts_project`.
Migrates `private/testing` to `ng_project`.
Removes the `@angular/bazel` package as we no longer need it. Yay!

It's replaced by `rules_angular`.
Replaces all `ng_package` rule with the new rule from `rules_angular`.
Migrates `packages/localize/schematics` to `ts_project`.
Fixes that the package diff script did not show newly untracked
files in the npm package.
…ular#61879)

Update the bazel query for finding all releasable packages to look for all targets with the name
`npm_package` that contain the expected tag.

PR Close angular#61879
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 5, 2025
@devversion
Copy link
Copy Markdown
Member Author

This PR was merged into the repository by commit e98ef80.

The changes were merged into the following branches: 20.0.x

devversion added a commit that referenced this pull request Jun 5, 2025
This commit migrates the remaining pieces of `compiler-cli` to
`ts_project`. This involves a few more things during migration:

- the `ng_module` ngc_wrapped rule broke as part of this change, so we
  switched it to `ts_project` too. This logic is soon gone anyway.

- we needed an extra pnpm "package.json" for the linker babel test. This test is
  loading from the real compiler-cli npm package. Babel needs a real
  node module for this, so this solution seems reasonable. It may be
  worth exploring in the future to move this test into an integration
  test though.

- the older integrationtest in compiler-cli is removed as the coverage
  is much better with the compliance test suite and this test.

PR Close #61862
devversion added a commit that referenced this pull request Jun 5, 2025
The bazel npm package is no longer needed and currently breaks
as we started using a 1P pnpm linked package that would otherwise
end up being pulled into this legacy rule.

PR Close #61862
devversion added a commit that referenced this pull request Jun 5, 2025
…61862)

Migrates remaining `ts_project` targets (excluding zone.js) to
`ts_project`.

PR Close #61862
devversion added a commit that referenced this pull request Jun 5, 2025
Migrates `private/testing` to `ng_project`.

PR Close #61862
devversion added a commit that referenced this pull request Jun 5, 2025
Removes the `@angular/bazel` package as we no longer need it. Yay!

It's replaced by `rules_angular`.

PR Close #61862
devversion added a commit that referenced this pull request Jun 5, 2025
…61862)

Replaces all `ng_package` rule with the new rule from `rules_angular`.

PR Close #61862
devversion added a commit that referenced this pull request Jun 5, 2025
Migrates `packages/localize/schematics` to `ts_project`.

PR Close #61862
@devversion devversion closed this Jun 5, 2025
devversion added a commit that referenced this pull request Jun 5, 2025
Fixes that the package diff script did not show newly untracked
files in the npm package.

PR Close #61862
devversion pushed a commit that referenced this pull request Jun 5, 2025
) (#61862)

Update the bazel query for finding all releasable packages to look for all targets with the name
`npm_package` that contain the expected tag.

PR Close #61879

PR Close #61862
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants