[20.0.x]: Patch port of #61843, and #61826#61862
Closed
devversion wants to merge 10 commits intoangular:20.0.xfrom
Closed
[20.0.x]: Patch port of #61843, and #61826#61862devversion wants to merge 10 commits intoangular:20.0.xfrom
devversion wants to merge 10 commits intoangular:20.0.xfrom
Conversation
Contributor
|
Please rebase this PR |
Member
Author
|
Rebased but this got conflicted again. I will merge myself tomorrow morning. |
This commit migrates the remaining pieces of `compiler-cli` to `ts_project`. This involves a few more things during migration: - the `ng_module` ngc_wrapped rule broke as part of this change, so we switched it to `ts_project` too. This logic is soon gone anyway. - we needed an extra pnpm "package.json" for the linker babel test. This test is loading from the real compiler-cli npm package. Babel needs a real node module for this, so this solution seems reasonable. It may be worth exploring in the future to move this test into an integration test though. - the older integrationtest in compiler-cli is removed as the coverage is much better with the compliance test suite and this test.
The bazel npm package is no longer needed and currently breaks as we started using a 1P pnpm linked package that would otherwise end up being pulled into this legacy rule.
Migrates remaining `ts_project` targets (excluding zone.js) to `ts_project`.
Migrates `private/testing` to `ng_project`.
Removes the `@angular/bazel` package as we no longer need it. Yay! It's replaced by `rules_angular`.
Replaces all `ng_package` rule with the new rule from `rules_angular`.
Migrates `packages/localize/schematics` to `ts_project`.
Fixes that the package diff script did not show newly untracked files in the npm package.
…lar` Fix two integration tests
…ular#61879) Update the bazel query for finding all releasable packages to look for all targets with the name `npm_package` that contain the expected tag. PR Close angular#61879
Member
Author
|
This PR was merged into the repository by commit e98ef80. The changes were merged into the following branches: 20.0.x |
devversion
added a commit
that referenced
this pull request
Jun 5, 2025
This commit migrates the remaining pieces of `compiler-cli` to `ts_project`. This involves a few more things during migration: - the `ng_module` ngc_wrapped rule broke as part of this change, so we switched it to `ts_project` too. This logic is soon gone anyway. - we needed an extra pnpm "package.json" for the linker babel test. This test is loading from the real compiler-cli npm package. Babel needs a real node module for this, so this solution seems reasonable. It may be worth exploring in the future to move this test into an integration test though. - the older integrationtest in compiler-cli is removed as the coverage is much better with the compliance test suite and this test. PR Close #61862
devversion
added a commit
that referenced
this pull request
Jun 5, 2025
The bazel npm package is no longer needed and currently breaks as we started using a 1P pnpm linked package that would otherwise end up being pulled into this legacy rule. PR Close #61862
devversion
added a commit
that referenced
this pull request
Jun 5, 2025
Migrates `private/testing` to `ng_project`. PR Close #61862
devversion
added a commit
that referenced
this pull request
Jun 5, 2025
Removes the `@angular/bazel` package as we no longer need it. Yay! It's replaced by `rules_angular`. PR Close #61862
devversion
added a commit
that referenced
this pull request
Jun 5, 2025
Migrates `packages/localize/schematics` to `ts_project`. PR Close #61862
devversion
added a commit
that referenced
this pull request
Jun 5, 2025
Fixes that the package diff script did not show newly untracked files in the npm package. PR Close #61862
devversion
pushed a commit
that referenced
this pull request
Jun 5, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch port of #61843, and #61826