refactor(core): Refactor createSignal to return a tuple#61705
Closed
tsc036 wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): Refactor createSignal to return a tuple#61705tsc036 wants to merge 1 commit intoangular:mainfrom
tsc036 wants to merge 1 commit intoangular:mainfrom
Conversation
…r, setter, and updater Refactor createSignal to return a tuple instead of a signal getter. createSignalTuple will be removed in a follow up pr once createSignalTuple usages in google3 are migrated to createSignal.
tbondwilkinson
approved these changes
May 27, 2025
Contributor
tbondwilkinson
left a comment
There was a problem hiding this comment.
But add the TGP run as well
pkozlowski-opensource
approved these changes
May 28, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-general
Reviewed-for: primitives
thePunderWoman
approved these changes
May 28, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
alxhub
approved these changes
Jun 2, 2025
Member
alxhub
left a comment
There was a problem hiding this comment.
Reviewed-for: fw-core, fw-primitives
Contributor
|
This PR was merged into the repository by commit ed0a0a6. The changes were merged into the following branches: main, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor createSignal to return a tuple instead of a signal getter. createSignalTuple will be removed in a follow up pr once createSignalTuple usages in google3 are migrated to createSignal.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
createSignalreturns a signal getter.Issue Number: N/A
What is the new behavior?
createSignalreturns a tuple containing a getter, setter, and update function.Does this PR introduce a breaking change?
Other information