Closed
Conversation
crisbeto
commented
May 21, 2025
crisbeto
commented
May 21, 2025
|
|
||
| it('should include field name in case of attribute interpolation', () => { | ||
| const message = `Previous value for 'attr.id': 'Expressions: a and initial!'. Current value: 'Expressions: a and changed!'`; | ||
| const message = `Expression has changed after it was checked. Previous value: 'initial'. Current value: 'changed'`; |
Member
Author
There was a problem hiding this comment.
This changed, because the error comes from the interpolate instructions which don't know what attribute they're bound to.
There was a problem hiding this comment.
Right, this makes the error message less useful but I think it is the tradeoff we should make
pkozlowski-opensource
approved these changes
May 21, 2025
|
|
||
| it('should include field name in case of attribute interpolation', () => { | ||
| const message = `Previous value for 'attr.id': 'Expressions: a and initial!'. Current value: 'Expressions: a and changed!'`; | ||
| const message = `Expression has changed after it was checked. Previous value: 'initial'. Current value: 'changed'`; |
There was a problem hiding this comment.
Right, this makes the error message less useful but I think it is the tradeoff we should make
Member
Author
Adds the new `interpolate*` instructions that can be passed into other instructions and used to replace our existing flavors of interpolations.
Replaces the attribute interpolation instructions with `attribute` plus the new `interpolateX` instruction. This allows to reduce our overall instruction footprint.
The attribute interpolation instructions aren't used anymore so we can remove them.
Updates the `bindingUpdated` function to handle `NO_CHANGE` instead of throwing. This will allow us to reuse instructions across more cases.
b717dd8 to
7ce1fd5
Compare
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
Adds the new `interpolate*` instructions that can be passed into other instructions and used to replace our existing flavors of interpolations. PR Close #61557
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
) Replaces the attribute interpolation instructions with `attribute` plus the new `interpolateX` instruction. This allows to reduce our overall instruction footprint. PR Close #61557
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
The attribute interpolation instructions aren't used anymore so we can remove them. PR Close #61557
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
Updates the `bindingUpdated` function to handle `NO_CHANGE` instead of throwing. This will allow us to reuse instructions across more cases. PR Close #61557
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
) Replaces the attribute interpolation instructions with `attribute` plus the new `interpolateX` instruction. This allows to reduce our overall instruction footprint. PR Close #61557
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
The attribute interpolation instructions aren't used anymore so we can remove them. PR Close #61557
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
Updates the `bindingUpdated` function to handle `NO_CHANGE` instead of throwing. This will allow us to reuse instructions across more cases. PR Close #61557
Contributor
|
This PR was merged into the repository by commit 1650a85. The changes were merged into the following branches: main, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the existing attribute interpolation instructions with a new format. For example previously we would generate
attributeInterpolate(name, ...)whereas now we generateattribute(name, interpolate(...)). This allows us to remove all of the specialized interpolation instructions.This initial PR only deals with attributes, but if there aren't any breakages, we can roll out the approach to all interpolations, saving us ~40 instructions from the set.