fix(compiler): avoid conflicts between HMR code and local symbols#61550
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): avoid conflicts between HMR code and local symbols#61550crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Currently we construct the HMR replacement URL inline by calling into the native `URL` constructor. This can cause conflicts with user code that defines a symbol called `URL`. These changes resolve the issue by moving the URL construction into a separate function. This has a secondary benefit of making the generated code easier to follow and allowing us to update the URL without changing the compiled code. Fixes angular#61517.
crisbeto
commented
May 21, 2025
| expect(jsContents).toContain('function Cmp_HmrLoad(t) {'); | ||
| expect(jsContents).toContain( | ||
| 'import(/* @vite-ignore */\nnew URL("./@ng/component?c=" + id + "&t=" + encodeURIComponent(t), import.meta.url).href)', | ||
| 'import(/* @vite-ignore */\ni0.ɵɵgetReplaceMetadataURL(id, t, import.meta.url)', |
Member
Author
There was a problem hiding this comment.
We could've fixed the bug by changing this to new globalThis.URL as well, but I feel like the dedicated function gives us more flexibility anyways.
clydin
approved these changes
May 21, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
…1550) Currently we construct the HMR replacement URL inline by calling into the native `URL` constructor. This can cause conflicts with user code that defines a symbol called `URL`. These changes resolve the issue by moving the URL construction into a separate function. This has a secondary benefit of making the generated code easier to follow and allowing us to update the URL without changing the compiled code. Fixes #61517. PR Close #61550
Contributor
|
This PR was merged into the repository by commit 46af023. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
…1550) Currently we construct the HMR replacement URL inline by calling into the native `URL` constructor. This can cause conflicts with user code that defines a symbol called `URL`. These changes resolve the issue by moving the URL construction into a separate function. This has a secondary benefit of making the generated code easier to follow and allowing us to update the URL without changing the compiled code. Fixes #61517. PR Close #61550
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we construct the HMR replacement URL inline by calling into the native
URLconstructor. This can cause conflicts with user code that defines a symbol calledURL.These changes resolve the issue by moving the URL construction into a separate function. This has a secondary benefit of making the generated code easier to follow and allowing us to update the URL without changing the compiled code.
Fixes #61517.