Migrate packages/core/test to ts_project#61472
Closed
devversion wants to merge 4 commits intoangular:mainfrom
Closed
Migrate packages/core/test to ts_project#61472devversion wants to merge 4 commits intoangular:mainfrom
packages/core/test to ts_project#61472devversion wants to merge 4 commits intoangular:mainfrom
Conversation
Member
Author
|
Caretaker note: Disabling pullapprove because |
josephperrott
approved these changes
May 19, 2025
Member
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
A couple small nits, but overall super excited for this to get in!
crisbeto
approved these changes
May 19, 2025
Member
Author
|
Caretaker note: This PR has a passing TGP |
These helpers are often imported by various tests throughout the repository, but the helpers aren't exported/exposed from the public entry-point; even though they confusingly reside in there. This commit fixes this, and moves the helpers into `packages/private/testing`. This is a preparation for the `ts_project` migration where we don't want to leverage deep imports between packages.
This commit migrates all `ts_library` in `package/core/test` to `ts_project`, and fixes deep module, or relative imports inside.
Migrates all `ng_module` to `ng_project` in `packages/core/test/`.
Avoids duplication of the `FactoryTarget` enums. This is necessary now because we are exposing the previously deeply-imported JIT facade now via the exports; and the typing integration tests surface a type conflict due to the different duplicated enums.
thePunderWoman
pushed a commit
that referenced
this pull request
May 20, 2025
This commit migrates all `ts_library` in `package/core/test` to `ts_project`, and fixes deep module, or relative imports inside. PR Close #61472
thePunderWoman
pushed a commit
that referenced
this pull request
May 20, 2025
Migrates all `ng_module` to `ng_project` in `packages/core/test/`. PR Close #61472
Contributor
|
This PR was merged into the repository by commit 7e57106. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits