Runtime refactor: move code out of instructions folder#61425
Closed
pkozlowski-opensource wants to merge 2 commits intoangular:mainfrom
Closed
Conversation
Move the i18n-related logic out of the instructions folder into the i18n-dedicated folder / package.
The view data store operation is not an instruction and shouldn't be located in the instructions folder.
alxhub
approved these changes
May 16, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
May 19, 2025
Move the i18n-related logic out of the instructions folder into the i18n-dedicated folder / package. PR Close #61425
thePunderWoman
pushed a commit
that referenced
this pull request
May 19, 2025
Move the i18n-related logic out of the instructions folder into the i18n-dedicated folder / package. PR Close #61425
Contributor
|
This PR was merged into the repository by commit 69984ef. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the many refactorings that tries to cleanup / re-dispatch code in the
instructionsfolder. The general idea is that theinstructionsshould only contain functions referenced in the generated code and the instructions functions should be, most of the time, delegating to the core framework logic / utility functions.