fix(core): TestBed.tick should ensure test components are synchronized#61382
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): TestBed.tick should ensure test components are synchronized#61382atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
pkozlowski-opensource
approved these changes
May 21, 2025
Member
|
This will need cleanup as there is a test reporting size increase. It is not clear to me if this is linked to this change or we've just accumulated changes over time :-/ (and our infra is not helping here...) |
Contributor
Author
|
@pkozlowski-opensource PTAL. Size tracking was unrelated and updated in https://github.com/angular/angular/pull/61261/files |
This ensures that `TestBed.tick` updates any components created with `TestBed.createComponent`, regardless of whether autoDetectChanges is on.
Contributor
|
This PR was merged into the repository by commit 971981e. The changes were merged into the following branches: main, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that
TestBed.tickupdates any components created withTestBed.createComponent, regardless of whether autoDetectChanges is on.