refactor: explicitly ensure ngDevMode types are available#61365
Closed
devversion wants to merge 1 commit intoangular:mainfrom
Closed
refactor: explicitly ensure ngDevMode types are available#61365devversion wants to merge 1 commit intoangular:mainfrom
ngDevMode types are available#61365devversion wants to merge 1 commit intoangular:mainfrom
Conversation
This commit adds an import to the `ng_dev_mode.ts` file that augments `global` to have types for `ngDevMode`. Notably this change is currently not needed because the file is loaded by `ts_library` through `tsconfig#files`— but in a separate PR we are switching the target to `ts_project` which no longer loads all Bazel dependency files via `tsconfig#files`; resulting in the ambient types no longer magically being available.
Member
Author
|
Caretaker note: Before syncing, we should submit cl/759088341 |
Contributor
|
Caretaker note: due to g3patches, this doesn't actually affect any of the shared primitives. So no TGP should be needed. This is safe to merge as is. |
thePunderWoman
pushed a commit
that referenced
this pull request
May 15, 2025
This commit adds an import to the `ng_dev_mode.ts` file that augments `global` to have types for `ngDevMode`. Notably this change is currently not needed because the file is loaded by `ts_library` through `tsconfig#files`— but in a separate PR we are switching the target to `ts_project` which no longer loads all Bazel dependency files via `tsconfig#files`; resulting in the ambient types no longer magically being available. PR Close #61365
thePunderWoman
pushed a commit
that referenced
this pull request
May 15, 2025
This commit adds an import to the `ng_dev_mode.ts` file that augments `global` to have types for `ngDevMode`. Notably this change is currently not needed because the file is loaded by `ts_library` through `tsconfig#files`— but in a separate PR we are switching the target to `ts_project` which no longer loads all Bazel dependency files via `tsconfig#files`; resulting in the ambient types no longer magically being available. PR Close #61365
Contributor
|
This PR was merged into the repository by commit ff62ff1. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an import to the
ng_dev_mode.tsfile that augmentsglobalto have types forngDevMode.Notably this change is currently not needed because the file is loaded by
ts_librarythroughtsconfig#files— but in a separate PR we are switching the target tots_projectwhich no longer loads all Bazel dependency files viatsconfig#files; resulting in the ambient types no longer magically being available.