Setup ng_project and migrate initial parts of packages/core#61275
Closed
devversion wants to merge 5 commits intoangular:mainfrom
Closed
Setup ng_project and migrate initial parts of packages/core#61275devversion wants to merge 5 commits intoangular:mainfrom
ng_project and migrate initial parts of packages/core#61275devversion wants to merge 5 commits intoangular:mainfrom
Conversation
b7510ec to
257fb21
Compare
josephperrott
approved these changes
May 13, 2025
Member
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
One little nit/question. But overall looks good. I am a bit lost on the tsec stuff in practice, but the temporary solution of moving it within the repo is fine with me.
ada41d4 to
cbbed5a
Compare
Member
Author
|
Caretaker note: Please follow these steps:
|
a0e67e4 to
4640619
Compare
c0bd6f2 to
dd75146
Compare
Supports the `ng_project` rule with the local compiler-cli version from HEAD.
Updates `packages/core:core` and `packages/core/src/...` to `ts_project` of `rules_js`.
This commit fixes that the interop targets weren't properly creating linker mappings in some cases. This could break spec bundling.
As we roll out more PRs that migrate to `ts_project`, we need to make sure that we don't break existing `tsec` targets. This PR copies the original `tsec` Starlark code and adjusts it to work with the interop. Note that we don't patch as this would unnecessarily complicate this file that only exists during migration. Long-term, after migration, we either need to consider switching to the new ESLint plugin that is being worked on (I'm in contact with the team), or we send a CL to update the Tsec Starlark code to keep our changes minimal and avoid scope increase.
Adds a script to diff snapshot packages to allow for easy verification that no unexpected changes were made.
thePunderWoman
pushed a commit
that referenced
this pull request
May 14, 2025
Updates `packages/core:core` and `packages/core/src/...` to `ts_project` of `rules_js`. PR Close #61275
thePunderWoman
pushed a commit
that referenced
this pull request
May 14, 2025
) As we roll out more PRs that migrate to `ts_project`, we need to make sure that we don't break existing `tsec` targets. This PR copies the original `tsec` Starlark code and adjusts it to work with the interop. Note that we don't patch as this would unnecessarily complicate this file that only exists during migration. Long-term, after migration, we either need to consider switching to the new ESLint plugin that is being worked on (I'm in contact with the team), or we send a CL to update the Tsec Starlark code to keep our changes minimal and avoid scope increase. PR Close #61275
Contributor
|
This PR was merged into the repository by commit 8e78b4e. The changes were merged into the following branches: main |
This was referenced May 14, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits