fix(core): cleanup testability subscriptions#61261
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): cleanup testability subscriptions#61261arturovt wants to merge 1 commit intoangular:mainfrom
arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
JeanMeche
reviewed
May 11, 2025
| }), | ||
| ); | ||
|
|
||
| this._destroyRef.onDestroy(() => { |
Member
There was a problem hiding this comment.
Wouldn't takeUntilDetroyed be more adequate ?
Contributor
Author
There was a problem hiding this comment.
It becomes a circular dependency (core depends on rxjs-interop and vice versa).
devversion
approved these changes
May 12, 2025
Member
Contributor
|
@arturovt Looks like there's a circular dependency added here. |
c1dff20 to
bc57aff
Compare
bc57aff to
5cdb1aa
Compare
5cdb1aa to
f987f88
Compare
Contributor
|
Looks like a broken integration test. |
f987f88 to
c747d54
Compare
This commit prevents leaking memory when the application is destroyed and subscriptions are still alive.
c747d54 to
278154d
Compare
thePunderWoman
approved these changes
May 21, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: size-tracking
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
This commit prevents leaking memory when the application is destroyed and subscriptions are still alive. PR Close #61261
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
This commit prevents leaking memory when the application is destroyed and subscriptions are still alive. PR Close #61261
Contributor
|
This PR was merged into the repository by commit 6bf6dbc. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit prevents leaking memory when the application is destroyed and subscriptions are still alive.